[
https://issues.apache.org/jira/browse/FELIX-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752745#comment-16752745
]
ASF GitHub Bot commented on FELIX-6026:
---------------------------------------
GitHub user tjwatson opened a pull request:
https://github.com/apache/felix/pull/172
FELIX-6026 - Fix ScrInfo service issues
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tjwatson/felix FELIX-6026
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/felix/pull/172.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #172
----
commit 07c1ebab265fc88fb95f34efad8a51e73220b009
Author: Tom Watson <tjwatson@...>
Date: 2019-01-25T14:27:14Z
FELIX-6026 - Fix ScrInfo service issues
----
> SCR command problems
> --------------------
>
> Key: FELIX-6026
> URL: https://issues.apache.org/jira/browse/FELIX-6026
> Project: Felix
> Issue Type: Bug
> Components: Declarative Services (SCR)
> Affects Versions: scr-2.1.14
> Reporter: Brent Daniel
> Priority: Major
>
> There are a couple of problems resulting from the changes to SCR commands in
> [https://github.com/apache/felix/pull/130] .
> First, ScrInfo is not registered as a service when ds.info.service=true is
> specified in config admin. The core issue is that the setScrCommand method of
> ScrConfigurationImpl is never called, so it will not be available in this
> block around line 208:
> {code:java}
> if ( scrCommand != null )
> {
> scrCommand.updateProvideScrInfoService( infoAsService() );
> }
> {code}
> That can be fixed by adding the following to the Activator.doStart() method
> (though I haven't spent much time thinking about better solutions):
> {code:java}
> m_configuration.setScrCommand(m_componentCommands);
> {code}
> Second, the ScrInfo list() and info() implementation no longer accept a null
> component ID. The javadoc for ScrInfo still indicates that a null ID will
> give information for all components. We have found this function invaluable
> for dumping the state of every component, so it would be nice to get this
> back.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
