[
https://issues.apache.org/jira/browse/FELIX-6137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850938#comment-16850938
]
Timothee Maret commented on FELIX-6137:
---------------------------------------
This prevents using the default converter (like
[here|https://github.com/apache/sling-org-apache-sling-distribution-journal-kafka/blob/master/src/test/java/org/apache/sling/distribution/journal/kafka/KafkaClientProviderTest.java#L119])
for annotations that don't specify a default. As part of this
[PR|https://github.com/apache/sling-org-apache-sling-distribution-journal-kafka/pull/5]
we'd ideally add such default-less property in this
[configuration|https://github.com/apache/sling-org-apache-sling-distribution-journal-kafka/blob/master/src/main/java/org/apache/sling/distribution/journal/kafka/KafkaEndpoint.java]
> Converting an default-less annotation property throws instead of returning
> null
> -------------------------------------------------------------------------------
>
> Key: FELIX-6137
> URL: https://issues.apache.org/jira/browse/FELIX-6137
> Project: Felix
> Issue Type: Bug
> Components: Converter
> Affects Versions: converter-1.0.8
> Reporter: Timothee Maret
> Priority: Major
>
> Converting a dictionary to an annotation that does not define a default value
> property throws a {{org.osgi.util.converter.ConversionException}} like the
> one below instead of returning {{null}}.
> {code}
> org.osgi.util.converter.ConversionException: No value for property: noDefault
> at
> org.osgi.util.converter.ConvertingImpl$4.invoke(ConvertingImpl.java:806)
> at org.osgi.util.converter.$Proxy9.noDefault(Unknown Source)
> at
> org.osgi.util.converter.ConverterMapTest.testDictionaryToAnnotationWithoutDefault(ConverterMapTest.java:520)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
