DominikSuess commented on a change in pull request #1: FELIX-6232 - adding 
option to install parallel version of bundle
URL: https://github.com/apache/felix-dev/pull/1#discussion_r388229007
 
 

 ##########
 File path: 
webconsole/src/main/java/org/apache/felix/webconsole/internal/core/BundlesServlet.java
 ##########
 @@ -1710,6 +1718,43 @@ private String getSymbolicName( File bundleFile )
         // fall back to "not found"
         return null;
     }
+    
+    private String getBundleVersion( File bundleFile )
+    {
+        JarFile jar = null;
+        try
+        {
+            jar = new JarFile( bundleFile );
 
 Review comment:
   The Felix Webconsole project is currently marked to be Java 6 compliant - 
this was just reproducing a pattern used already before for bsn - I just 
changed this based on suggestion by Carsten below to make sure to use a single 
method to obtain bsn & version

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to