stbischof commented on a change in pull request #10: [converter] handle default
methods - FELIX-6239
URL: https://github.com/apache/felix-dev/pull/10#discussion_r398522828
##########
File path:
converter/converter/src/main/java/org/osgi/util/converter/ConvertingImpl.java
##########
@@ -810,6 +813,32 @@ public Object invoke(Object proxy, Method method,
Object[] args)
if (cls.isAnnotation()) {
val = method.getDefaultValue();
}
+ else if (method.isDefault())
+ {
+ double javaVersion =
Double.parseDouble(
+
System.getProperty("java.class.version"));
+ double java8 = 52.0;
+ if (javaVersion > java8)
Review comment:
Yes. I didn't found one way that works in 8 and 9+
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
