[ https://issues.apache.org/jira/browse/FELIX-6251?focusedWorklogId=418631&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-418631 ]
ASF GitHub Bot logged work on FELIX-6251: ----------------------------------------- Author: ASF GitHub Bot Created on: 08/Apr/20 15:31 Start Date: 08/Apr/20 15:31 Worklog Time Spent: 10m Work Description: tjwatson commented on pull request #15: FELIX-6251 - Fix NPE in DependencyManager for references to m_tracker URL: https://github.com/apache/felix-dev/pull/15 Need to ensure the tracker is not null. Also calls to tracked can return null and need to be handled without an NPE ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 418631) Remaining Estimate: 0h Time Spent: 10m > Possible NullPointerException when DependencyManager.m_tracker is null > ---------------------------------------------------------------------- > > Key: FELIX-6251 > URL: https://issues.apache.org/jira/browse/FELIX-6251 > Project: Felix > Issue Type: Bug > Components: Declarative Services (SCR) > Affects Versions: scr-2.1.16 > Reporter: Tom Watson > Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The following NullPointerException can happen once the tracker is closed and > nulled out. There are a few places where a null check is done. But there > are many more where the null > org.apache.felix.scr.impl.manager.DependencyManager.m_tracker would cause an > NPE. > {code:java} > FrameworkEvent ERROR java.lang.NullPointerException > at > org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.removedService(DependencyManager.java:379) > at > org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.removedService(DependencyManager.java:296) > at > org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerRemoved(ServiceTracker.java:1242) > at > org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerRemoved(ServiceTracker.java:1137) > at > org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.untrack(ServiceTracker.java:997) > at > org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:1176) > at > org.apache.felix.scr.impl.BundleComponentActivator$ListenerInfo.serviceChanged(BundleComponentActivator.java:125) > at > org.eclipse.osgi.internal.serviceregistry.FilteredServiceListener.serviceChanged(FilteredServiceListener.java:113) > at > org.eclipse.osgi.internal.framework.BundleContextImpl.dispatchEvent(BundleContextImpl.java:985) > at > org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:234) > at > org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:151) > at > org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.publishServiceEventPrivileged(ServiceRegistry.java:896) > at > org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.publishServiceEvent(ServiceRegistry.java:834) > at > org.eclipse.osgi.internal.serviceregistry.ServiceRegistrationImpl.unregister(ServiceRegistrationImpl.java:227) > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)