[ https://issues.apache.org/jira/browse/FELIX-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tuomas Kiviaho updated FELIX-6460: ---------------------------------- Description: I seem to have introduced a bug along my patch for FELIX-3381. Edit: I've actually failed to verify the actual patch patch https://svn.apache.org/viewvc/felix/trunk/bundleplugin/src/main/java/org/apache/felix/bundleplugin/BundlePlugin.java?revision=1602812&view=markup&pathrev=1695270 There is should be a test in BundlePlugin.java whether \{maven-sources} and/or \{maven-test-sources} placeholders are present but instead I've managed miss a typo \{maven-test-resources} that was patched there instead. Could this simple typo be fixed {code:java|title=BundlePlugin.java} @@ -2143,7 +2143,7 @@ final String sourcePath = analyzer.getProperty( Analyzer.SOURCEPATH ); if ( sourcePath != null ) { - if ( sourcePath.contains(MAVEN_SOURCES) || sourcePath.contains(MAVEN_TEST_RESOURCES) ) + if ( sourcePath.contains(MAVEN_SOURCES) || sourcePath.contains(MAVEN_TEST_SOURCES) ) { String combinedSource = StringUtils.replace( sourcePath, MAVEN_SOURCES, mavenSourcePaths.toString() ); combinedSource = StringUtils.replace( combinedSource, MAVEN_TEST_SOURCES, mavenTestSourcePaths.toString() ); {code} was: I seem to have introduced a bug along my patch for FELIX-3381. There is should be a test in BundlePlugin.java whether \{maven-sources} and/or \{maven-test-sources} placeholders are present but instead I've managed to typo \{maven-test-resources} there instead. Could this simple typo be fixed {code:java|title=BundlePlugin.java} @@ -2143,7 +2143,7 @@ final String sourcePath = analyzer.getProperty( Analyzer.SOURCEPATH ); if ( sourcePath != null ) { - if ( sourcePath.contains(MAVEN_SOURCES) || sourcePath.contains(MAVEN_TEST_RESOURCES) ) + if ( sourcePath.contains(MAVEN_SOURCES) || sourcePath.contains(MAVEN_TEST_SOURCES) ) { String combinedSource = StringUtils.replace( sourcePath, MAVEN_SOURCES, mavenSourcePaths.toString() ); combinedSource = StringUtils.replace( combinedSource, MAVEN_TEST_SOURCES, mavenTestSourcePaths.toString() ); {code} > {maven-test-sources} not working as expected > -------------------------------------------- > > Key: FELIX-6460 > URL: https://issues.apache.org/jira/browse/FELIX-6460 > Project: Felix > Issue Type: Bug > Components: Maven Bundle Plugin > Affects Versions: maven-bundle-plugin-2.5.0, maven-bundle-plugin-5.1.2 > Reporter: Tuomas Kiviaho > Priority: Blocker > > I seem to have introduced a bug along my patch for FELIX-3381. > Edit: I've actually failed to verify the actual patch patch > https://svn.apache.org/viewvc/felix/trunk/bundleplugin/src/main/java/org/apache/felix/bundleplugin/BundlePlugin.java?revision=1602812&view=markup&pathrev=1695270 > There is should be a test in BundlePlugin.java whether \{maven-sources} > and/or \{maven-test-sources} placeholders are present but instead I've > managed miss a typo \{maven-test-resources} that was patched there instead. > Could this simple typo be fixed > {code:java|title=BundlePlugin.java} > @@ -2143,7 +2143,7 @@ > final String sourcePath = analyzer.getProperty( Analyzer.SOURCEPATH > ); > if ( sourcePath != null ) > { > - if ( sourcePath.contains(MAVEN_SOURCES) || > sourcePath.contains(MAVEN_TEST_RESOURCES) ) > + if ( sourcePath.contains(MAVEN_SOURCES) || > sourcePath.contains(MAVEN_TEST_SOURCES) ) > { > String combinedSource = StringUtils.replace( sourcePath, > MAVEN_SOURCES, mavenSourcePaths.toString() ); > combinedSource = StringUtils.replace( combinedSource, > MAVEN_TEST_SOURCES, mavenTestSourcePaths.toString() ); > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)