Hi Carsten,
I made a little tweak to FELIX-6481 (please double-check), also in
general I made some more improvements/fixes [1], if that all works for
you like this I would create a release vote some time next week...
-Georg
[1]
https://issues.apache.org/jira/issues/?jql=project%20%3D%20FELIX%20AND%20fixVersion%20%3D%20%22healthcheck.core%202.0.12%22
https://issues.apache.org/jira/issues/?jql=project%20%3D%20FELIX%20AND%20fixVersion%20%3D%20%22healthcheck.generalchecks%203.0.0%22
On 2021-12-07 15:58, Carsten Ziegeler wrote:
Hi,
yes, makes sense to keep format - thanks, I'll create an issue for that
one
Regards
Carsten
Am 07.12.2021 um 15:50 schrieb Georg Henzler:
Hi Carsten,
generally this makes sense. Currently we have the param list [1] in
the html rendering, I could imagine a config option
'disableRequestConfiguration' - but I think it could be good to leave
the format option open as this is just response format and not really
config. WDYT?
-Georg
[1]
Supported URL parameters
tags:Comma-separated list of health checks tags to select - can also
be specified via path, e.g. /system/health/tag1,tag2.json. Exclusions
can be done by prepending '-' to the tag name
names:Comma-separated list of health check names to select. Exclusions
can be done by prepending '-' to the health check name
format:Output format, html|json|jsonp|txt - an extension in the URL
overrides this
httpStatus:Specify HTTP result code, for example CRITICAL:503 (status
503 if result >= CRITICAL) or
CRITICAL:503,HEALTH_CHECK_ERROR:500,OK:418 for more specific HTTP
status
combineTagsWithOr:Combine tags with OR, active by default. Set to
false to combine with AND
forceInstantExecution:If true, forces instant execution by executing
async health checks directly, circumventing the cache (2sec by
default) of the HealthCheckExecutor
timeout:(msec) a timeout status is returned for any health check still
running after this period. Overrides the default HealthCheckExecutor
timeout
hcDebug:Include the DEBUG output of the Health Checks
callback:name of the JSONP callback function to use, defaults to
processHealthCheckResults
[2]
https://github.com/apache/felix-dev/blob/master/healthcheck/core/src/main/java/org/apache/felix/hc/core/impl/servlet/HealthCheckExecutorServletConfiguration.java
On 2021-12-07 15:16, Carsten Ziegeler wrote:
Hi Georg,
while we are discuss HC here :) I was thinking about adding another
osgi config to HealthCheckExecutorServlet to allow to lock it down
and ignoring any parameters send in via http. Does that sound
reasonable to you?
Regards
Carsten
