tjwatson commented on a change in pull request #131:
URL: https://github.com/apache/felix-dev/pull/131#discussion_r824782058
##########
File path: scr/src/main/java/org/apache/felix/scr/impl/ComponentRegistry.java
##########
@@ -732,7 +732,7 @@ public void updateChangeCount()
final Timer timer;
synchronized ( this.changeCountTimerLock ) {
if ( this.changeCountTimer == null ) {
- this.changeCountTimer = new Timer();
+ this.changeCountTimer = new Timer("SCR Component
Registry");
Review comment:
Thanks, my thought is that I cannot think of any reason we would want
this thread to hold up the JVM from exiting. The Framework itself is
responsible to make sure there is at least one non-daemon thread active while
the framework is running. But once the framework has stopped I think the JVM
should be free to exit, even in the off chance that this timer is still active.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
