cziegeler commented on code in PR #170: URL: https://github.com/apache/felix-dev/pull/170#discussion_r938778902
########## configurator/src/main/java/org/apache/felix/configurator/impl/model/State.java: ########## @@ -39,9 +39,8 @@ public class State extends AbstractState implements Serializable { public static final String FILE_NAME = "state.ser"; - private Map<Long, Long> bundlesLastModified = new HashMap<>(); - - private Map<Long, Long> bundlesConfigAdminBundleId = new HashMap<>(); + private Map<Long, Long> bundlesLastModified = new ConcurrentHashMap<>(); Review Comment: Its used for versioning of the serialized format, it makes it easier to make any change to this class in future versions. It might be a little bit overkill here But at least it allows to change the type of the map when reading already serialized objects - and that's what I think is missing in this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org