[
https://issues.apache.org/jira/browse/FELIX-6612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759121#comment-17759121
]
Michael H. Siemaszko commented on FELIX-6612:
---------------------------------------------
[~cziegeler]
Ever since work done as part of
{color:#000080}+[https://github.com/apache/felix-dev/pull/218]+{color} and
{color:#000080}+[https://github.com/apache/felix-dev/pull/217]+{color} was
delivered by me, I’ve noticed a significant increase in frequency of commits
and issues opened and almost immediately closed as resolved. Majority of these
is work done as part of this “Upgrade Apache Felix to Jakarta Servlet API 6.x”
({color:#000080}+https://issues.apache.org/jira/browse/FELIX-6612+{color}),
which was split into two milestones – first of which was “Upgrade Apache Felix
to Jakarta Servlet API 5.x”
({color:#000080}+[https://github.com/apache/felix-dev/pull/217]+{color}), and
subsequently “Upgrade Apache Felix to Jakarta Servlet API 6.x”
({color:#000080}+[https://github.com/apache/felix-dev/pull/218]+{color}).
However, those commits and issues you entered as yourself.
{+}I would like to ask you{+}:
({*}1{*}) for clarification why you said work done as part of milestone 1
({color:#000080}+[https://github.com/apache/felix-dev/pull/217]+{color}) is not
needed and that PR was closed by you, not merged; however, all these sudden
commits and issues closed / resolved in such short amount of time over the
course of past 2 weeks is mostly work done and provided via that PR – you can
refer to Mikado Graph / mind-map ([^Upgrade Apache Felix to Jakarta Servlet API
6.x.20230731.pdf]), attached to this issue
{color:#000080}+https://issues.apache.org/jira/browse/FELIX-6612+{color}, and
you will notice large majority of items, including removal of dependency on
HTTP Service / Migration to Servlet Whiteboard / Migration to Jakarta Servlet
API / etc., are items on that graph / mind-map and contained in commits
delivered in PR
{color:#000080}+[https://github.com/apache/felix-dev/pull/217];+{color}
({*}2{*}) for clarification why I have not received any responses to questions
asked repeatedly in
{color:#000080}+https://issues.apache.org/jira/browse/FELIX-6612+{color}; I’ve
asked several questions, both in summary of this issue
{color:#000080}+https://issues.apache.org/jira/browse/FELIX-6612+{color} in the
first week of June, and in its comments, and repeated those questions several
times in June and July, then I waited close to a month before commencing with
work – it appears only after PR
{color:#000080}+[https://github.com/apache/felix-dev/pull/217|https://github.com/apache/felix-dev/pull/217w]+{color}
was closed and
{color:#000080}+[https://github.com/apache/felix-dev/pull/218|https://github.com/apache/felix-dev/pull/218m]+{color}
merged, you started to “answer” those questions by creating commits / issues /
etc. – a lot of time/work would have been saved had those questions been
answered back then;
({*}3{*}) to acknowledge, that having refactored modules (removal of dependency
on HTTP Service / Migration to Servlet Whiteboard / Migration to Jakarta
Servlet API / etc.) – i.e. work “you” did as part of those recent commits –
only then it was not needed to branch multiple modules on
{color:#000080}+[https://github.com/apache/felix-dev/tree/jakarta-servlet-6]+{color}
branch – all these modules needed to be branched initially, and you can again
refer to Mikado Graph / mind map ([^Upgrade Apache Felix to Jakarta Servlet API
6.x.20230731.pdf]) attached to
{color:#000080}+https://issues.apache.org/jira/browse/FELIX-6612+{color}, as
well as commits made as part of
{color:#000080}+[https://github.com/apache/felix-dev/pull/217]+{color} and
{color:#000080}+[https://github.com/apache/felix-dev/pull/218]+{color}, for
details;
Specific issues and commits you made to which I’m referring are:
* (FELIX-6628) Migrate http webconsoleplugin to Jakarta Servlet API
{color:#000080}+https://issues.apache.org/jira/browse/FELIX-6628+{color}
* (FELIX-6627) Migrate inventory to jakarta.servlet API
{color:#000080}+https://issues.apache.org/jira/browse/FELIX-6627+{color}
* (FELIX-6626) Support jakarta servlet registration
{color:#000080}+https://issues.apache.org/jira/browse/FELIX-6626+{color}
* (FELIX-6631) Migrate webconsole plugins to jakarta.servlet api
{color:#000080}+https://issues.apache.org/jira/browse/FELIX-6631+{color}
* (FELIX-6635) Remove dependency to HttpService
{color:#000080}+https://issues.apache.org/jira/browse/FELIX-6635+{color}
* (FELIX-6623) Use Http Whiteboard for Web Console registration
{color:#000080}+https://issues.apache.org/jira/browse/FELIX-6623+{color}
* (FELIX-6636) Migrate to Jakarta Servlet Whiteboard
{color:#000080}+https://issues.apache.org/jira/browse/FELIX-6636+{color}
* [felix-dev] branch master updated: Make sure module works with jakarta
servlet 6
* [felix-dev] branch master updated: Unmaintained code removal – examples/jaas
* [felix-dev] branch master updated: Unmaintained code removal –
webconsole-plugins/useradmin
* [felix-dev] branch master updated: Unmaintained code removal –
webconsole-plugins/upnp
* [felix-dev] branch master updated: Unmaintained code removal –
webconsole-plugins/subsystems
* [felix-dev] branch master updated: Unmaintained code removal –
webconsole-plugins/shell
* [felix-dev] branch master updated: Unmaintained code removal –
webconsole-plugins/deppack
* [felix-dev] branch jakarta-servlet-6 updated: No need to fork
webconsoleplugin
* [felix-dev] branch jakarta-servlet-6 updated: No need to branch webconsole
plugins
* [felix-dev] branch jakarta-servlet-6 updated: No need to branch webconsole
l18n modules
* [felix-dev] branch jakarta-servlet-6 updated: No need to branc event
webconsole plugin
* [felix-dev] branch jakarta-servlet-6 updated: No need for separate branch
for ds plugin
* [felix-dev] 01/03: No need to branch depback plugin
* [felix-dev] branch jakarta-servlet-6 updated: No need to fork samples
* [felix-dev] branch jakarta-servlet-6 updated: No need to fork
inventoryprinter
* [felix-dev] branch jakarta-servlet-6 updated: No need for a separate branch
for inventory; we can continue on the master branch
* [felix-dev] branch jakarta-servlet-6 updated: Remove sslfilter from branch -
version from master works for servlet 5 and 6
* [felix-dev] branch jakarta-servlet-6 updated: No need to branch healthchecks
Just to be clear: I do not have a problem with using my work, however, I do
have a problem when my work is not attributed to me properly. Work done as part
of PRs {color:#000080}+[https://github.com/apache/felix-dev/pull/218]+{color}
and {color:#000080}+[https://github.com/apache/felix-dev/pull/217]+{color} had
no compilation issues, unit and integration tests worked, and those artifacts
were also verified as part of an actual project
({color:#000080}+[https://github.com/geckoprojects-org/org.gecko.graphql/pull/8]+{color}).
I’ve also asked repeatedly if there are any issues which I should resolve as
part code review, but no such were pointed out.
I appreciate addressing above mentioned 3 points so this is resolved amicably
and I can make sure that time and effort I put in and share with open source
community is attributed properly.
> Upgrade Apache Felix to Jakarta Servlet API 6.x
> -----------------------------------------------
>
> Key: FELIX-6612
> URL: https://issues.apache.org/jira/browse/FELIX-6612
> Project: Felix
> Issue Type: New Feature
> Components: Health Checks, HTTP Service, Inventory, iPOJO, JAAS,
> System Ready, Web Console
> Reporter: Michael H. Siemaszko
> Assignee: Michael H. Siemaszko
> Priority: Major
> Attachments: Upgrade Apache Felix to Jakarta Servlet API
> 6.x.20230713.pdf, Upgrade Apache Felix to Jakarta Servlet API
> 6.x.20230731.pdf, Upgrade Apache Felix to Jakarta Servlet API 6.x.pdf
>
>
> Goal is to upgrade all relevant Apache Felix modules, which currently are
> using either +Jakarta Servlet API 5.x+ or J{+}ava Servlet{+}, to {+}Jakarta
> Servlet API 6.x{+}.
> Attached Mikado graph ({color:#000080}+[https://mikadomethod.info/]+{color})
> has all so far identified prerequisites listed, as well as progress on path
> to main goal – i.e. items already completed are checked off
> ({*}{color:#57d9a3}green icon{color}{*}). Code is shared via
> [https://github.com/DataInMotion/felix-dev/tree/jakarta-servlet-6-x] (no pull
> request for now – please see sections ‘Questions’ and ‘Next steps’ below).
> Before starting, I asked on Apache Felix Users list
> ({color:#000080}+[https://www.mail-archive.com/users@felix.apache.org/msg18693.html]+{color}),
> as well as researched if there is any ongoing effort to upgrade Apache Felix
> to Jakarta Servlet 6.x (issues / pull requests, etc.). Besides
> {color:#000080}+https://issues.apache.org/jira/browse/FELIX-6389+{color},
> which resembles this effort, I did not find anything. However, that issue is
> open since 22/02/2021 and there has been no updates since 09/01/2022, as well
> as no code shared as part of it. If any progress was made as part of
> {color:#000080}+https://issues.apache.org/jira/browse/FELIX-6389+{color},
> kindly please provide status update and perhaps these efforts can be merged.
> h1. Modules affected
> Modules with dependency on Java Servlet or Jakarta Servlet.
> h2. org.apache.felix.http
> * org.apache.felix.http.parent
> * org.apache.felix.http.base
> * org.apache.felix.http.bridge
> * org.apache.felix.http.inventoryprinter
> * org.apache.felix.http.itest
> * org.apache.felix.http.jetty
> * org.apache.felix.http.proxy
> * org.apache.felix.http.samples.whiteboard
> * org.apache.felix.http.servlet-api
> * org.apache.felix.http.sslfilter
> * org.apache.felix.http.webconsoleplugin
> h2. org.apache.felix.webconsole
> * org.apache.felix.webconsole
> * org.apache.felix.webconsole.plugins.deppack
> * org.apache.felix.webconsole.plugins.ds
> * org.apache.felix.webconsole.plugins.event
> * org.apache.felix.webconsole.plugins.gogo
> * org.apache.felix.webconsole.plugins.memoryusage
> * org.apache.felix.webconsole.plugins.metatype
> * org.apache.felix.webconsole.plugins.obr
> * org.apache.felix.webconsole.plugins.packageadmin
> * org.apache.felix.webconsole.plugins.scriptconsole
> * org.apache.felix.webconsole.plugins.shell
> * org.apache.felix.webconsole.plugins.subsystems
> * org.apache.felix.webconsole.plugins.upnp
> * org.apache.felix.webconsole.plugins.useradmin
> h2. org.apache.felix.healthcheck
> * org.apache.felix.healthcheck.core
> * org.apache.felix.healthcheck.webconsoleplugin
> h2. Other
> * org.apache.felix.jaas
> * org.apache.felix.example.jaas.app
> * org.apache.felix.example.jaas.jdbc-h2
> * org.apache.felix.ipojo.webconsole
> * org.apache.felix.systemready
> * org.apache.felix.servicediagnostics.plugin
> * org.apache.felix.inventory
> h1. Questions
> 1. Regarding modules affected, are there any additional modules which should
> be taken into account?
> 2. Regarding modules affected, should any of the modules listed be dropped
> from that list ? (e.g. some may be out of date / replaced by other already)
> 3. Do you know of any ongoing effort to migrate `org.osgi.service.http`
> specification to Jakarta ? How otherwise should modules currently using
> `org.osgi.service.http` specification API classes and methods be refactored ?
> I am aware of
> {color:#000080}+[https://github.com/eclipse-equinox/equinox/issues/183]+{color}
> but it is not clear to me from that discussion if any such effort will be
> actually made.
> 4. Do you know of any ongoing effort to upgrade `org.osgi.service.servlet` to
> support Jakarta Servlet API 6.x ?
> 5. If `javax.servlet` dependency is removed from
> `org.apache.felix.http.base`, wouldn't the wrappers become obsolete ? I.e.
> shouldn't `org.apache.felix.http.base.internal.jakartawrappers` and
> `org.apache.felix.http.base.internal.javaxwrappers` be dropped then and
> Jakarta Servlet API used directly ?
> 6. Should Jakarta Servlet API 5.x be supported in parallel with Jakarta
> Servlet API 6.x (as hinted at in
> {color:#000080}+[https://www.mail-archive.com/users@felix.apache.org/msg18694.html]+{color}),
> or only Jakarta Servlet API 6.x ?
> 7. Should `org.apache.felix.http.servlet-api` module be kept once dependency
> on Java Servlet API is removed from it?
> 8. Should this be merged to `master` branch @
> {color:#000080}+[https://github.com/apache/felix-dev]+{color} once ready, or
> dedicated branch should be used (e.g. `jakarta-servlet-6-x`)
> h1. Next steps
> 1. Please provide answers to questions mentioned in previous section.
> 2. If you see any of the prerequisites missing from Mikado graph, please
> mention those.
> 3. Please create a dedicated branch @
> {color:#000080}+[https://github.com/apache/felix-dev]+{color} (e.g.
> `jakarta-servlet-6-x`) unless this should be merged to `master` once ready.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
