cziegeler commented on code in PR #305:
URL: https://github.com/apache/felix-dev/pull/305#discussion_r1558883795
##########
webconsole/src/main/java/org/apache/felix/webconsole/internal/servlet/OsgiManagerHttpContext.java:
##########
@@ -63,19 +66,23 @@ public URL getResource(final String name) {
@Override
public boolean handleSecurity( final HttpServletRequest r, final
HttpServletResponse response ) {
+
final WebConsoleSecurityProvider provider = tracker.getService();
+ final String webManagerRoot = this.webManagerRoot;
// for compatibility we have to adjust a few methods on the request
final HttpServletRequest request = new HttpServletRequestWrapper(r) {
@Override
public String getContextPath() {
- return "";
+ int managerRootIndex =
r.getContextPath().lastIndexOf(webManagerRoot);
+ return r.getContextPath().substring(0, managerRootIndex);
}
@Override
public String getServletPath() {
- return r.getContextPath();
+ int managerRootIndex =
r.getContextPath().indexOf(webManagerRoot);
Review Comment:
For consistency I think we should use lastIndexOf here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
