cziegeler commented on code in PR #308:
URL: https://github.com/apache/felix-dev/pull/308#discussion_r1580489168
##########
http/jetty12/src/main/java/org/apache/felix/http/jetty/internal/JettyService.java:
##########
@@ -564,6 +566,18 @@ private void
configureHttpConnectionFactory(HttpConnectionFactory connFactory)
config.setResponseHeaderSize(this.config.getHeaderSize());
config.setOutputBufferSize(this.config.getResponseBufferSize());
+ String uriComplianceMode =
this.config.getProperty(JettyConfig.FELIX_JETTY_URI_COMPLIANCE_MODE, null);
+ if (uriComplianceMode != null) {
+ config.setUriCompliance(UriCompliance.valueOf(uriComplianceMode));
Review Comment:
If the value is not one from the enum, this will throw an exception, I think
we should catch this, log and use the default
##########
http/jetty12/src/main/java/org/apache/felix/http/jetty/internal/JettyService.java:
##########
@@ -564,6 +566,18 @@ private void
configureHttpConnectionFactory(HttpConnectionFactory connFactory)
config.setResponseHeaderSize(this.config.getHeaderSize());
config.setOutputBufferSize(this.config.getResponseBufferSize());
+ String uriComplianceMode =
this.config.getProperty(JettyConfig.FELIX_JETTY_URI_COMPLIANCE_MODE, null);
+ if (uriComplianceMode != null) {
+ config.setUriCompliance(UriCompliance.valueOf(uriComplianceMode));
+
+ if ("LEGACY".equals(uriComplianceMode) ||
"UNSAFE".equals(uriComplianceMode)
Review Comment:
you could use the enum here instead of string comparison
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
