paulrutter commented on code in PR #310:
URL: https://github.com/apache/felix-dev/pull/310#discussion_r1584151474
##########
http/jetty12/src/main/java/org/apache/felix/http/jetty/internal/JettyService.java:
##########
@@ -253,9 +253,12 @@ private void initializeJetty() throws Exception
loginService.setUserStore(new UserStore());
this.server.addBean(loginService);
- ServletContextHandler context = new
ServletContextHandler(this.config.getContextPath(),
+ ServletContextHandler context = new
ServletContextHandler(this.config.getContextPath(),
ServletContextHandler.SESSIONS);
+ // To support WebSockets via
https://github.com/apache/felix-dev/pull/310
+ context.setCrossContextDispatchSupported(true);
Review Comment:
From what i can find, cross context support allows for dospatching requests
between different Jetty contexts, as can be seen in
https://github.com/jetty/jetty.project/issues/10617.
For Felix HTTP there is only one context, so i would assume there are no
side-effects, but i'm not sure of this.
I agree that having a proper alternative would be better though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
