laeubi commented on code in PR #359:
URL: https://github.com/apache/felix-dev/pull/359#discussion_r1881586322
##########
log/pom.xml:
##########
@@ -49,6 +49,30 @@
<groupId>org.osgi</groupId>
<artifactId>osgi.core</artifactId>
<version>6.0.0</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.osgi</groupId>
+ <artifactId>org.osgi.namespace.service</artifactId>
+ <version>1.0.0</version>
+ </dependency>
+ <dependency>
+ <groupId>org.osgi</groupId>
+ <artifactId>osgi.annotation</artifactId>
+ <version>8.1.0</version>
+ <optional>true</optional>
+ </dependency>
+ <dependency>
+ <groupId>org.osgi</groupId>
+ <artifactId>org.osgi.service.component.annotations</artifactId>
+ <version>1.5.1</version>
+ <optional>true</optional>
Review Comment:
I don't think that optional is correct here. As you mentioned the doc states
that optional should be used if there are different providers (e.g. slf4j, jpa,
jms,...) and not to hide something (what is shown to the user is then more a
decision of the tooling)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
