laeubi commented on PR #367: URL: https://github.com/apache/felix-dev/pull/367#issuecomment-2583364930
> but i would expect commons-fileupload to be marked optional in the pom.xml Please note that "optional" means something totally different to maven, see https://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html Optional is similar to "provided" but should not be included into runtime collections e.g. `slf4-api` will be `compile` and `slf4-simple` will be optional runtime because one might choose a different implementation of the API **but it wont work without any provided**! Optional in OSGi mean it could work with or without this dependency, is really hard to get correct and almost never useful if not carefully crafted and tested. Especially in this case it might lead to hard to track runtime errors, so `ClassNotFound` Exceptions should be catched somewhere and output a meaningful message so the user understands how to resolve the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
