paulrutter commented on PR #399: URL: https://github.com/apache/felix-dev/pull/399#issuecomment-2771613171
@cziegeler I checked out the changes, but i see the WS related unit test now fails. To your points: * it does not check that getting the servlet might result in null -> this is clear * it gets the servlets twice, at least in the case of normal whiteboard handling -> clear, but the behavior is not the same as before The unit tests fail now: ``` [INFO] [INFO] Results: [INFO] [ERROR] Errors: [ERROR] JettySpecificWebsocketIT.testWebSocketServletWhiteboard ┬╗ Upgrade Failed to upgrade to websocket: Unexpected HTTP Response Status Code: 500 Server Error [INFO] [ERROR] Tests run: 10, Failures: 0, Errors: 1, Skipped: 0 [INFO] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
