tjwatson commented on code in PR #487:
URL: https://github.com/apache/felix-dev/pull/487#discussion_r2983381073
##########
scr/src/main/java/org/apache/felix/scr/impl/ComponentRegistry.java:
##########
@@ -727,32 +732,43 @@ public void updateChangeCount()
{
final long count = this.changeCount.incrementAndGet();
- try
+ synchronized ( changeCountUpdateTaskLock )
Review Comment:
This adds synchronization to a large code block. It should be scoped down
to only what it is protecting.
But I prefer not to use this approach because it still schedules a large
number of tasks unnecessarily and then will attempt to cancel them rapidly
which could cause other contentions that could lead to another performance
issue.
I would prefer we stick with PR #486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
