paulrutter commented on PR #554: URL: https://github.com/apache/felix-dev/pull/554#issuecomment-5464791792
Added the TCK dependency fixes to this branch, because the TCK cannot resolve on master at all and it is the thing that demonstrates the `FilterImpl` fix. CI on the first push failed with: ``` Error : assertj-core;version=[3.27.3,3.27.4) Not found in [... assertj-core;version=3.27.7 ...] ``` That is pre-existing master breakage, not fallout from this change. Two ranges were left behind when assertj-core was bumped 3.27.3 to 3.27.7 in #478: 1. `tck.bndrun` still required `assertj-core [3.27.3,3.27.4)`, so the bndrun could not resolve and no test ran. 2. Once that resolves, assertj-core 3.27.7 imports `net.bytebuddy [1.18.0,2.0.0)` while byte-buddy was pinned at 1.17.5, so assertj-core failed to start with an unresolved `osgi.wiring.package` requirement. Both are fixed here, along with a duplicate `junit-platform-launcher` declaration that Maven flags as a malformed model. Scope note: #433 additionally moves the bnd plugins and `biz.aQute.junit` to 7.4.0, because bnd 6.4.1's launcher calls `Policy.setPolicy()` unguarded and Java 24+ rejects that. That one is JDK-24-and-later specific, so it is deliberately left in #433 rather than pulled in here — master's matrix is 17, 21 and 23, which are unaffected. With these in place the TCK should actually execute on this branch, which is what makes the `FilterImpl` fix verifiable rather than just asserted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
