paulrutter commented on PR #556: URL: https://github.com/apache/felix-dev/pull/556#issuecomment-5465033438
Restacked onto #555 and narrowed to just the code fix. CI could not build this: `configadmin` has the same stale parent defect as the other modules in #555 — it declares `felix-parent 6`, which does not match the local pom, so Maven resolves the released parent from Central and gets `felix.java.version 7`: ``` error: release version 7 not supported ``` That build repair belongs in #555, which is exactly "make the remaining module builds work on modern JDKs", so it has moved there along with adding `configadmin` to the CI matrix. This PR now contains only the `Thread.stop()` → `interrupt()` change and is stacked on #555 so it inherits a working build. Worth noting separately: `configadmin` was absent from the workflow's path filters entirely, so this PR initially matched no trigger and received **no CI at all** rather than a failure. That is a recurring weakness — a module outside the path list gets silence instead of a red build. It has bitten `gogo`, `framework.tck`, stacked PR base branches and now `configadmin`; a catch-all entry or a default that fails loudly would be safer than enumerating every module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
