slachiewicz opened a new pull request, #592: URL: https://github.com/apache/felix-dev/pull/592
[FELIX-6876](https://issues.apache.org/jira/browse/FELIX-6876): the remote OBR goals (`bundle:deploy` with `remoteOBR`, `bundle:deploy-file`, `bundle:remote-clean`) no longer use maven-compat's `WagonManager`, and no longer depend on the `wagon-file` and `wagon-http` providers Maven ships in `lib/`. - `RemoteFileManager` looks the Wagon up by protocol in the plugin's container (the call `WagonManager.getWagon` made), takes credentials from the matching settings `<server>` through `SettingsDecrypter`, and keeps using the first active proxy, whose password is now decrypted too. The Wagon is released after use. - The plugin declares `wagon-file` and `wagon-http` 3.5.3; other protocols still come from build extensions. - `maven-compat` stays for now: `BundlePlugin`, `BundleAllPlugin` and `AbstractBaselinePlugin` still use its `ArtifactResolver`, `ArtifactCollector` and `MavenProjectBuilder` (FELIX-6606). Verified: `install bundle:deploy -DremoteOBR` against a `file://` OBR and an HTTP OBR with and without Basic auth, run twice so `repository.xml` is created and then merged → passes on Maven 3.9.16 and 4.0.0-rc-7; on a 3.9.16 copy without `lib/wagon-file*` and `lib/wagon-http*`, master fails with `Unsupported protocol: 'file'` and this change passes. `mvn verify` in the module: 38 tests (9 new) and 14 ITs pass. Not run end to end: `deploy-file`, `remote-clean`, scp/sftp through an extension, a real proxy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
