paulrutter commented on PR #595: URL: https://github.com/apache/felix-dev/pull/595#issuecomment-6891676710
Thanks for the fix. One blocker: Backslashes are doubled on round trip. appendValue writes \ as \\, but bnd (checked with bndlib 7.4.0) only unescapes \" when it parses a quoted value. It does not turn \\ back into \. A filter such as (pid=a\(b) is therefore written as "(pid=a\\(b)" and read back as (pid=a\\(b), which is a different and invalid filter. Before this PR, backslashes passed through unchanged, so this is a regression for any value with an LDAP-escaped character (\(, \), \*, \\). Suggested fix: in appendValue, escape only " and leave \ as is. Please also add a test with a backslash in a filter. Minor, not blocking: the new assertions only run for mode == "service", so the generic mode is not covered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
