Hi Duplex, Your PR seems to be buggy because of conflict you have caused in merging the upstream, One quick solution is to make a new fork of the community app and then make clean changes and send a new PR.
I merged your PR before but it broke everything in community app so reverted it back, Above solution which i suggest is the quickest one. Let me know if you any problem. Waiting for your PR Regards Mohit On 5 May 2017 at 01:47, Santosh Math <sant...@confluxtechnologies.com> wrote: > Mohit, > > Looks like this is the long awaited solution. Check his PR and merge it if > no conflicts. We will deploy the code on newbeta and test it whether its > solution. > > Thanks > Santosh > > On May 4, 2017 11:20 PM, "Kamdjou Duplex" <kamdjou.dup...@skylabase.com> > wrote: > >> Hi Mohit, >> >> I generate a production package (dist) and deplyed and run it on my local >> server and it works. >> and i am 95% sure that it will work now in production. >> >> The problem was some css files which was not called with the right path >> and >> some was not even get copy to the production package while building. So, I >> edited the gruntFile.js and the styles-dev stucture to solve that. >> >> Thanks >> >> On Thu, May 4, 2017 at 3:39 PM, Mohit Bajoria <mohitbaj...@gmail.com> >> wrote: >> >> > Hello Duplex >> > >> > Thanks for looking into the issue, but how did you verify that it worked >> > in production ? Because locally it worked perfect and i was unable to >> find >> > out the reason of not working in production >> > >> > Regards >> > Mohit >> > >> > On 4 May 2017 at 18:49, Kamdjou Duplex <kamdjou.dup...@skylabase.com> >> > wrote: >> > >> >> here is the PR all the test pass please review it >> >> https://github.com/openMF/community-app/pull/2198 >> >> >> >> On Thu, May 4, 2017 at 1:15 PM, Kamdjou Duplex < >> >> kamdjou.dup...@skylabase.com> wrote: >> >> >> >>> Yes this #1967 issue >> >>> >> >>> what about this? I should not care about sentense ? >> >>> This branch is 68 commits ahead, 35 commits behind openMF:develop. >> >>> >> >>> >> >>> On Thu, May 4, 2017 at 1:11 PM, Santosh Math < >> >>> sant...@confluxtechnologies.com> wrote: >> >>> >> >>>> Hi Kamdjou, >> >>>> >> >>>> Which issue are you able to resolve? #1967? Reskin related PRs >> are >> >>>> sent >> >>>> to new_reskin branch >> >>>> >> >>>> Santosh >> >>>> >> >>>> On Thu, May 4, 2017 at 5:24 PM, Kamdjou Duplex < >> >>>> kamdjou.dup...@skylabase.com >> >>>> > wrote: >> >>>> >> >>>> > hello @Ed, @Santosh, @Mohit, >> >>>> > >> >>>> > Good news! the issue have been solve. But I want you to guide me on >> >>>> how to >> >>>> > proceed on this to sent a PR. I am see this after push to the >> newskin >> >>>> > branch of my fork. >> >>>> > >> >>>> > This branch is 68 commits ahead, 35 commits behind openMF:develop. >> >>>> > >> >>>> > Please I need a detail guide on this. I don't want to mess anything >> >>>> out :) >> >>>> > >> >>>> > Duplex, >> >>>> > >> >>>> > On Thu, May 4, 2017 at 10:25 AM, Kamdjou Duplex < >> >>>> > kamdjou.dup...@skylabase.com> wrote: >> >>>> > >> >>>> > > Okay thanks I will talk with Mohit to solve that. >> >>>> > > >> >>>> > > On Thu, May 4, 2017 at 10:20 AM, Santosh Math < >> >>>> > > sant...@confluxtechnologies.com> wrote: >> >>>> > > >> >>>> > >> Hi Kamdjou, >> >>>> > >> >> >>>> > >> Yes, that's true. Some libraries are not loading properly. I >> have >> >>>> added >> >>>> > >> Mohit to this loop who knows it better. >> >>>> > >> >> >>>> > >> Thanks >> >>>> > >> Santosh >> >>>> > >> >> >>>> > >> >> >>>> > >> >> >>>> > >> On Thu, May 4, 2017 at 2:47 PM, Kamdjou Duplex < >> >>>> > >> kamdjou.dup...@skylabase.com >> >>>> > >> > wrote: >> >>>> > >> >> >>>> > >> > @Santosh, >> >>>> > >> > concerning this critical issue https://github.com/openMF/ >> >>>> > >> > community-app/issues/1967. >> >>>> > >> > >> >>>> > >> > I just want to be sure that, you have rebuild the production >> >>>> package >> >>>> > of >> >>>> > >> a >> >>>> > >> > working local of this and put it on the server and it still >> not >> >>>> > working? >> >>>> > >> > >> >>>> > >> > >> >>>> > >> > On Thu, May 4, 2017 at 9:13 AM, Kamdjou Duplex < >> >>>> > >> > kamdjou.dup...@skylabase.com >> >>>> > >> > > wrote: >> >>>> > >> > >> >>>> > >> > > Okay thanks for all your inputs. I am starting like this >> and I >> >>>> will >> >>>> > >> get >> >>>> > >> > > back to you as soon as I need help >> >>>> > >> > > >> >>>> > >> > > thanks >> >>>> > >> > > >> >>>> > >> > > On Thu, May 4, 2017 at 8:14 AM, Santosh Math >> >>>> > >> > <santosh@confluxtechnologies. >> >>>> > >> > > com> wrote: >> >>>> > >> > > >> >>>> > >> > >> Hi Kamdjou, >> >>>> > >> > >> Consider this is very very critical/blocker issue for >> >>>> reskin >> >>>> > >> release. >> >>>> > >> > >> https://github.com/openMF/community-app/issues/1967 >> >>>> > >> > >> >> >>>> > >> > >> P.S:When we run this in our local machine with code fetched >> >>>> from >> >>>> > >> > >> new_reskin >> >>>> > >> > >> branch, this issue doesn't exist. This issue exists only >> in >> >>>> > >> > demo(newbeta) >> >>>> > >> > >> >> >>>> > >> > >> https://demo.openmf.org/newbeta/ >> >>>> > >> > >> >> >>>> > >> > >> Thanks >> >>>> > >> > >> Santosh >> >>>> > >> > >> >> >>>> > >> > >> On Thu, May 4, 2017 at 11:58 AM, Santosh Math < >> >>>> > >> > >> sant...@confluxtechnologies.com> wrote: >> >>>> > >> > >> >> >>>> > >> > >> > Hi Kamdjou, >> >>>> > >> > >> > >> >>>> > >> > >> > It's pleasure to have you back. By the way, any issues >> with >> >>>> > label >> >>>> > >> p1, >> >>>> > >> > >> > consider them as high priority issues. >> >>>> > >> > >> > >> >>>> > >> > >> > https://github.com/openMF/community-app/labels/p1 >> >>>> > >> > >> > >> >>>> > >> > >> > Thanks >> >>>> > >> > >> > Santosh >> >>>> > >> > >> > >> >>>> > >> > >> > On Wed, May 3, 2017 at 9:59 PM, Kamdjou Duplex < >> >>>> > >> > >> > kamdjou.dup...@skylabase.com> wrote: >> >>>> > >> > >> > >> >>>> > >> > >> >> Hi Ed, Mohit and Everyone, >> >>>> > >> > >> >> >> >>>> > >> > >> >> It have been long without me been in touch with the >> >>>> community. I >> >>>> > >> have >> >>>> > >> > >> just >> >>>> > >> > >> >> been receiveing mails about the good progress you guys >> are >> >>>> > making. >> >>>> > >> > >> >> >> >>>> > >> > >> >> So, I just want to know if there are priority tasks on >> the >> >>>> > Reskin >> >>>> > >> App >> >>>> > >> > >> or >> >>>> > >> > >> >> from where should I start. >> >>>> > >> > >> >> >> >>>> > >> > >> >> I will be happy to put somehands onthe remaining #TODO >> :) >> >>>> > >> > >> >> >> >>>> > >> > >> >> Thanks, >> >>>> > >> > >> >> Duplex >> >>>> > >> > >> >> >> >>>> > >> > >> >> -- >> >>>> > >> > >> >> *_____________________________ >> >>>> ______________________________ >> >>>> > >> > >> >> ________________________* >> >>>> > >> > >> >> >> >>>> > >> > >> >> *Kamdjou Temfack Duplex M Phone: +237 670274538* >> >>>> > >> > >> >> * >> >>>> +237 >> >>>> > >> > >> >> 693301346* >> >>>> > >> > >> >> *_____________________________ >> >>>> ______________________________ >> >>>> > >> > >> >> ________________________* >> >>>> > >> > >> >> >> >>>> > >> > >> >> *Lead Frontend Engineer Sky.labase < >> >>>> http://www.skylabase.com/>* >> >>>> > >> > >> >> *OpenSource Contributor Mifos Initiative < >> >>>> http://mifos.org/>* >> >>>> > >> > >> >> *_____________________________ >> >>>> ______________________________ >> >>>> > >> > >> >> ________________________* >> >>>> > >> > >> >> *Twitter:* @tony14pro <https://twitter.com/Tony14Pro> >> >>>> > >> > >> >> *Github:* https://github.com/kamdjouduplex >> >>>> > >> > >> >> *Website:* http://kamdjouduplex.github.io/ >> >>>> > >> > >> >> <https://kamdjou-resume.firebaseapp.com/> >> >>>> > >> > >> >> >> >>>> > >> > >> >> *_____________________________ >> >>>> ______________________________ >> >>>> > >> > >> >> ________________________ >> >>>> > >> > >> >> <https://kamdjou-resume.firebaseapp.com/>* >> >>>> > >> > >> >> >> >>>> > >> > >> > >> >>>> > >> > >> > >> >>>> > >> > >> >> >>>> > >> > > >> >>>> > >> > > >> >>>> > >> > > >> >>>> > >> > > -- >> >>>> > >> > > >> >>>> > >> > > *_____________________________ >> ______________________________ >> >>>> > >> > _______________________* >> >>>> > >> > > >> >>>> > >> > > *Kamdjou Temfack Duplex M Phone: +237 670274538 >> >>>> > >> > > <+237%206%2070%2027%2045%2038>* >> >>>> > >> > > * >> >>>> +237 >> >>>> > >> > 693301346 >> >>>> > >> > > <+237%206%2093%2030%2013%2046>* >> >>>> > >> > > >> >>>> > >> > > *_____________________________ >> ______________________________ >> >>>> > >> > _______________________* >> >>>> > >> > > >> >>>> > >> > > *Lead Frontend Engineer Sky.labase < >> http://www.skylabase.com/ >> >>>> >* >> >>>> > >> > > *OpenSource Contributor Mifos Initiative <http://mifos.org/ >> >* >> >>>> > >> > > >> >>>> > >> > > *_____________________________ >> ______________________________ >> >>>> > >> > ________________________* >> >>>> > >> > > *Twitter:* @tony14pro <https://twitter.com/Tony14Pro> >> >>>> > >> > > *Github:* https://github.com/kamdjouduplex >> >>>> > >> > > *Website:* http://kamdjouduplex.github.io/ >> >>>> > >> > > <https://kamdjou-resume.firebaseapp.com/> >> >>>> > >> > > >> >>>> > >> > > *_____________________________ >> ______________________________ >> >>>> > >> > ________________________ >> >>>> > >> > > <https://kamdjou-resume.firebaseapp.com/>* >> >>>> > >> > > >> >>>> > >> > >> >>>> > >> > >> >>>> > >> > >> >>>> > >> > -- >> >>>> > >> > *___________________________________________________________ >> >>>> > >> > _______________________* >> >>>> > >> > >> >>>> > >> > *Kamdjou Temfack Duplex M Phone: +237 670274538* >> >>>> > >> > * >> +237 >> >>>> > >> 693301346* >> >>>> > >> > *___________________________________________________________ >> >>>> > >> > _______________________* >> >>>> > >> > >> >>>> > >> > *Lead Frontend Engineer Sky.labase <http://www.skylabase.com/ >> >* >> >>>> > >> > *OpenSource Contributor Mifos Initiative <http://mifos.org/>* >> >>>> > >> > *___________________________________________________________ >> >>>> > >> > ________________________* >> >>>> > >> > *Twitter:* @tony14pro <https://twitter.com/Tony14Pro> >> >>>> > >> > *Github:* https://github.com/kamdjouduplex >> >>>> > >> > *Website:* http://kamdjouduplex.github.io/ >> >>>> > >> > <https://kamdjou-resume.firebaseapp.com/> >> >>>> > >> > >> >>>> > >> > *___________________________________________________________ >> >>>> > >> > ________________________ >> >>>> > >> > <https://kamdjou-resume.firebaseapp.com/>* >> >>>> > >> > >> >>>> > >> >> >>>> > > >> >>>> > > >> >>>> > > >> >>>> > > -- >> >>>> > > >> >>>> > > *___________________________________________________________ >> >>>> > _______________________* >> >>>> > > >> >>>> > > *Kamdjou Temfack Duplex M Phone: +237 670274538 >> >>>> > > <+237%206%2070%2027%2045%2038>* >> >>>> > > * +237 >> >>>> > 693301346 >> >>>> > > <+237%206%2093%2030%2013%2046>* >> >>>> > > >> >>>> > > *___________________________________________________________ >> >>>> > _______________________* >> >>>> > > >> >>>> > > *Lead Frontend Engineer Sky.labase <http://www.skylabase.com/>* >> >>>> > > *OpenSource Contributor Mifos Initiative <http://mifos.org/>* >> >>>> > > >> >>>> > > *___________________________________________________________ >> >>>> > ________________________* >> >>>> > > *Twitter:* @tony14pro <https://twitter.com/Tony14Pro> >> >>>> > > *Github:* https://github.com/kamdjouduplex >> >>>> > > *Website:* http://kamdjouduplex.github.io/ >> >>>> > > <https://kamdjou-resume.firebaseapp.com/> >> >>>> > > >> >>>> > > *___________________________________________________________ >> >>>> > ________________________ >> >>>> > > <https://kamdjou-resume.firebaseapp.com/>* >> >>>> > > >> >>>> > >> >>>> > >> >>>> > >> >>>> > -- >> >>>> > *___________________________________________________________ >> >>>> > _______________________* >> >>>> > >> >>>> > *Kamdjou Temfack Duplex M Phone: +237 670274538* >> >>>> > * +237 >> >>>> 693301346* >> >>>> > *___________________________________________________________ >> >>>> > _______________________* >> >>>> > >> >>>> > *Lead Frontend Engineer Sky.labase <http://www.skylabase.com/>* >> >>>> > *OpenSource Contributor Mifos Initiative <http://mifos.org/>* >> >>>> > *___________________________________________________________ >> >>>> > ________________________* >> >>>> > *Twitter:* @tony14pro <https://twitter.com/Tony14Pro> >> >>>> > *Github:* https://github.com/kamdjouduplex >> >>>> > *Website:* http://kamdjouduplex.github.io/ >> >>>> > <https://kamdjou-resume.firebaseapp.com/> >> >>>> > >> >>>> > *___________________________________________________________ >> >>>> > ________________________ >> >>>> > <https://kamdjou-resume.firebaseapp.com/>* >> >>>> > >> >>>> >> >>> >> >>> >> >>> >> >>> -- >> >>> >> >>> *___________________________________________________________ >> _______________________* >> >>> >> >>> *Kamdjou Temfack Duplex M Phone: +237 670274538 >> >>> <+237%206%2070%2027%2045%2038>* >> >>> * +237 >> >>> 693301346 <+237%206%2093%2030%2013%2046>* >> >>> >> >>> *___________________________________________________________ >> _______________________* >> >>> >> >>> *Lead Frontend Engineer Sky.labase <http://www.skylabase.com/>* >> >>> *OpenSource Contributor Mifos Initiative <http://mifos.org/>* >> >>> >> >>> *___________________________________________________________ >> ________________________* >> >>> *Twitter:* @tony14pro <https://twitter.com/Tony14Pro> >> >>> *Github:* https://github.com/kamdjouduplex >> >>> *Website:* http://kamdjouduplex.github.io/ >> >>> <https://kamdjou-resume.firebaseapp.com/> >> >>> >> >>> *___________________________________________________________ >> ________________________ >> >>> <https://kamdjou-resume.firebaseapp.com/>* >> >>> >> >> >> >> >> >> >> >> -- >> >> >> >> *___________________________________________________________ >> _______________________* >> >> >> >> *Kamdjou Temfack Duplex M Phone: +237 670274538 >> >> <+237%206%2070%2027%2045%2038>* >> >> * +237 >> >> 693301346 <+237%206%2093%2030%2013%2046>* >> >> >> >> *___________________________________________________________ >> _______________________* >> >> >> >> *Lead Frontend Engineer Sky.labase <http://www.skylabase.com/>* >> >> *OpenSource Contributor Mifos Initiative <http://mifos.org/>* >> >> >> >> *___________________________________________________________ >> ________________________* >> >> *Twitter:* @tony14pro <https://twitter.com/Tony14Pro> >> >> *Github:* https://github.com/kamdjouduplex >> >> *Website:* http://kamdjouduplex.github.io/ >> >> <https://kamdjou-resume.firebaseapp.com/> >> >> >> >> *___________________________________________________________ >> ________________________ >> >> <https://kamdjou-resume.firebaseapp.com/>* >> >> >> > >> > >> > >> > -- >> > >> > *Regards* >> > *Mohit Kumar Bajoria* >> > *http://mohitbajoria.com <http://mohitbajoria.com>* >> > >> >> >> >> -- >> *___________________________________________________________ >> _______________________* >> >> *Kamdjou Temfack Duplex M Phone: +237 670274538* >> * +237 >> 693301346* >> *___________________________________________________________ >> _______________________* >> >> *Lead Frontend Engineer Sky.labase <http://www.skylabase.com/>* >> *OpenSource Contributor Mifos Initiative <http://mifos.org/>* >> *___________________________________________________________ >> ________________________* >> *Twitter:* @tony14pro <https://twitter.com/Tony14Pro> >> *Github:* https://github.com/kamdjouduplex >> *Website:* http://kamdjouduplex.github.io/ >> <https://kamdjou-resume.firebaseapp.com/> >> >> *___________________________________________________________ >> ________________________ >> <https://kamdjou-resume.firebaseapp.com/>* >> > -- *Regards* *Mohit Kumar Bajoria* *http://mohitbajoria.com <http://mohitbajoria.com>*
