Hello Sanyam,Ed,Nazeer and Avik As the annotations for portfolio branch are to be inserted, merging this PR will not be feasible. The remaining work can be converted into GCI tasks and once the PR is completed we can merge it.
I was also having concern over manually inserting /swagger.json or /swagger.yml after we have build the application. I am not 100% sure if this will work, but I have seen people generating the files during compile time, https://tech.homeaway.com/development/2016/06/02/generating-swagger-spec.html Although this has been done in maven. For bit level task, I can take the lead for mentoring GCI students to get this PR completed. Regards, Nikhil On Wed, Oct 11, 2017 at 7:23 AM, Sanyam Goel <sanyam.bvco...@gmail.com> wrote: > Hi, > > I have solved the merge conflict with the develop branch. > > Thanks, > > On Mon, Oct 9, 2017 at 2:29 PM, Sanyam Goel <sanyam.bvco...@gmail.com> > wrote: > >> Hi Nikhil, Ed, Nazeer, >> >> I'll solve the conflicting files in the PR within this week most >> probably by Thursday. >> >> Thanks, >> >> On Sun, Oct 8, 2017 at 1:37 PM, Ed Cable <edca...@mifos.org> wrote: >> >>> Yes just mentors for now... >>> >>> On Sun, Oct 8, 2017 at 12:52 AM, Nikhil Pawar <nickr...@gmail.com> >>> wrote: >>> >>>> Sure Ed, is the meeting just for mentors? >>>> >>>> Regards, >>>> Nikhil >>>> >>>> On Sunday 8 October 2017, 2:47:07 AM GMT-5, Ed Cable <edca...@mifos.org> >>>> wrote: >>>> >>>> >>>> Nikhil, >>>> >>>> Could you re-send this sam email to the Apache Fineract dev list so >>>> this discussion can happen publicly. >>>> >>>> As an FYI, we the GSOC mentors have a meeting this Tuesday to do a >>>> check-in on where all our projects from GSOC stand with merging. >>>> >>>> Ed >>>> >>>> On Sat, Oct 7, 2017 at 4:09 PM, Nikhil Pawar <nickr...@gmail.com> >>>> wrote: >>>> >>>> Hi Sanyan, >>>> >>>> Hope you are doing well. >>>> I wanted to start with the review of swagger implementation. >>>> Could you please correct the conflicting files in the PR. >>>> In the meanwhile, I am going to clone your PR and start understanding >>>> its functionality. >>>> >>>> >>>> Regards, >>>> Nikhil >>>> >>>> >>>> >>>> >>>> -- >>>> *Ed Cable* >>>> President/CEO, Mifos Initiative >>>> edca...@mifos.org | Skype: edcable | Mobile: +1.484.477.8649 >>>> <(484)%20477-8649> >>>> >>>> *Collectively Creating a World of 3 Billion Maries | *http://mifos.org >>>> <http://facebook.com/mifos> <http://www.twitter.com/mifos> >>>> >>>> >>> >>> >>> -- >>> *Ed Cable* >>> President/CEO, Mifos Initiative >>> edca...@mifos.org | Skype: edcable | Mobile: +1.484.477.8649 >>> <(484)%20477-8649> >>> >>> *Collectively Creating a World of 3 Billion Maries | *http://mifos.org >>> <http://facebook.com/mifos> <http://www.twitter.com/mifos> >>> >>> >> >> >> -- >> SANYAM GOEL >> LinkedIn: https://goo.gl/6SJMg3 >> Github: https://goo.gl/u51wRZ >> Hackerrank: https://goo.gl/4kzLf7 >> +91-9818060934 <+91%2098180%2060934> >> > > > > -- > SANYAM GOEL > LinkedIn: https://goo.gl/6SJMg3 > Github: https://goo.gl/u51wRZ > Hackerrank: https://goo.gl/4kzLf7 > +91-9818060934 <+91%2098180%2060934> >
