aasaru commented on a change in pull request #6: FINCN-165: Implement bash
scripts to provisioner fineract cn services
URL:
https://github.com/apache/fineract-cn-docker-compose/pull/6#discussion_r326286036
##########
File path: bash_scripts/provision.sh
##########
@@ -0,0 +1,318 @@
+#!/bin/bash
+set -e
+
+function init-variables {
+ local file="../env_variables"
+
+ CASSANDRA_REPLICATION_TYPE="Simple"
+ CASSANDRA_CONTACT_POINTS='172.16.238.68:9042' #initialized by the start-up
script
Review comment:
I wonder why you don't use DNS names instead of IP addresses.
You could use "cassandra-ms" instead of Cassandra IP. And similarly you
could use "postgres-ms" instead of Postgres IP. The same goes with all other
IP-s. If you could use DNS names instead of IP addresses then it would be more
compatible with Mac as the Docker IP addresses don't work in Mac. Docker DNS
addresses don't work either in Mac but a workaround for them is to add them to
/etc/hosts and make them all point at 127.0.0.1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
