Hi Awasum, First, I fetched the latest code from develop branch of Apache/Fineract into my local machine. Then, I cherry-picked the following commits into my local machine before running integration test. https://github.com/ivan333m/fineract/commit/1e0e6ca3e749c7408c610f54791f7ec68910e655 https://github.com/ivan333m/fineract/commit/1d9176505b1aec16c6c7a5065f73775728e31dab https://github.com/ivan333m/fineract/commit/33acc37a764b5b30fce5cbfa8b34239680d2c381
However, I checked build.gradle file and it's still 1.x as you said. How to upgrade it? I did "./gradlew -Penv=dev clean cleanEclipse eclipse" and getting the following error: FAILURE: Build failed with an exception. * Where: Script '/home/conflux/fineract/fineract/fineract-provider/dev-dependencies.gradle' line: 30 * What went wrong: A problem occurred evaluating script. > Could not find method providedCompile() for arguments [] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler. * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org BUILD FAILED in 7s On Fri, Nov 22, 2019 at 5:20 PM Awasum Yannick <awa...@apache.org> wrote: > Hi Santosh, > > Your logs show you are using spring boot 1.x and spring 4.x. I am not sure > you are using right PR. we have not yet merged the PR for the upgrade. See > here: https://github.com/apache/fineract/pull/642 > > We simply requested more people to test the PR to make sure most things > are working correctly before we merge, especially the spring security > aspect of things. > > So pull the PR locally and test to see if all is fine. > > Thanks. > Awasum > > On Fri, Nov 22, 2019 at 12:35 PM Santosh Math < > sant...@confluxtechnologies.com> wrote: > >> Hi All, >> I am doing Integration test locally and the commit, "FINERACT-724 >> disable csrf on oauth configuration" causing the build to fail and I have >> attached the error log with this mail. >> >> However, the other two commits - "FINERACT-724 fix oauth configuration" & >> "FINERACT-724 fix travis build after spring version migration" - Currently, >> Integration test is going on and let you know soon. >> >> Let me know if I am missing anything. >> >> On Thu, Nov 21, 2019 at 5:17 PM Awasum Yannick <awa...@apache.org> wrote: >> >>> Hi All, >>> >>> We now have Travis passing again for >>> https://github.com/apache/fineract/pull/642 >>> >>> This is ready to go, I think. >>> >>> One thing I have not done is to test the security aspect to make sure >>> the upgrade to spring boot 2.1.7 has not caused any problems. >>> >>> Please, will a few people help to test the PR locally, especially the >>> spring security side of things. Probably by end of day or tomorrow, I will >>> merge the PR and if there are any subsequent issues, we can fix in the >>> coming days and weeks. >>> >>> This is critical for Fineract 1.x, we have always been using spring boot >>> 1.2 (Spring 4.x). This new PR upgrades Fineract 1.x to Spring Boot 2.1.7 >>> (Spring 5.x). This is a major change and I encourage more people to test >>> this. >>> >>> Thanks. >>> Awasum >>> >>> On Thu, Nov 21, 2019 at 12:37 PM Awasum Yannick <awa...@apache.org> >>> wrote: >>> >>>> Hi Ivan, >>>> >>>> >>>> >>>> On Thu, Nov 21, 2019 at 10:26 AM Ivan Bondarenko <ivan3...@gmail.com> >>>> wrote: >>>> >>>>> Hi, Ed, Awasum, All >>>>> >>>>> 1) My tests are passing locally, I have ran it many times. >>>>> 2) My local machine has really powerful configuration. I think there >>>>> is some race conditions in the integration tests that cause the random >>>>> test >>>>> fail. >>>>> >>>> >>>> I noticed this. Even on Travis you see some Optimistic locking problems >>>> once in a while. Maybe an issue should be created for this? >>>> >>>> >>>>> 3) Awasum, I have just connected mifos-comunity app to the upgraded >>>>> version of the back-endand it works fine. >>>>> Do you use basic auth mode? If not please update the code. I have just >>>>> committed fix for oauth config, hope it helps. >>>>> If you use basic - could you confirm that >>>>> `V353__migrate_passwords_to_ss_5.sql` was executed on startup? >>>>> >>>> >>>> Yes,..I missed this..I was using my old DB for testing which had flyway >>>> versions above 353 and so could not log in. I used a clean DB now and i can >>>> login from UI. Thanks Ivan. >>>> >>>> >>>>> PS: Unfortunately I have found that integration tests have bugs and >>>>> some critical cases are not covered, examples : >>>>> 1) As I can see >>>>> `HookIntegrationTest.shouldSendOfficeCreationNotification` will pas in any >>>>> case, it has no assertions(just "sout" logging) >>>>> 2) I can't find tests with oauth config >>>>> 3) Can't find test for documents and image uploads >>>>> 4) I think there is some race conditions on job execution and job's >>>>> status checks in integration tests. (I hope get it wrong) >>>>> >>>>> I will create jira issues for found problems, but a little bit later. >>>>> (If someone confirm the described issues it would be really helpfull) >>>>> >>>> >>>> You are right on all the above. Go ahead and create issues on Jira for >>>> these. >>>> >>>> Thanks for your contributions and patience, Ivan. >>>> >>>> чт, 21 нояб. 2019 г. в 09:51, Awasum Yannick <awa...@apache.org>: >>>>> >>>>>> Hi All, >>>>>> >>>>>> I left some review comments here: >>>>>> https://github.com/apache/fineract/pull/642#issuecomment-556962459 >>>>>> on why Travis is failing and also problems when connecting the front >>>>>> end to the upgraded (Spring 5.x) Fineract branch/PR. >>>>>> >>>>>> Any ideas? >>>>>> >>>>>> On Wed, Nov 20, 2019 at 11:18 PM Ed Cable <edca...@mifos.org> wrote: >>>>>> >>>>>>> Hi all, >>>>>>> >>>>>>> I just wanted to follow up on this as we're trying to wrap up the >>>>>>> 1.4 release and bring it to a vote. >>>>>>> >>>>>>> Ed >>>>>>> >>>>>>> On Fri, Nov 15, 2019 at 12:01 PM Ed Cable <edca...@mifos.org> wrote: >>>>>>> >>>>>>>> Michael and Ivan, >>>>>>>> >>>>>>>> So we can ship the 1.4 release on time, I wanted to inquire about >>>>>>>> the status of merging https://github.com/apache/fineract/pull/642 >>>>>>>> >>>>>>>> Is there anything blocking it? It looks like Ivan's test are >>>>>>>> passing locally but the build is still failing. >>>>>>>> >>>>>>>> Once that's merged, I believe we can then merge >>>>>>>> https://github.com/apache/fineract/pull/649 >>>>>>>> >>>>>>>> THanks, >>>>>>>> >>>>>>>> Ed >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> -- >>>>>>> *Ed Cable* >>>>>>> President/CEO, Mifos Initiative >>>>>>> edca...@mifos.org | Skype: edcable | Mobile: +1.484.477.8649 >>>>>>> >>>>>>> *Collectively Creating a World of 3 Billion Maries | * >>>>>>> http://mifos.org <http://facebook.com/mifos> >>>>>>> <http://www.twitter.com/mifos> >>>>>>> >>>>>>> >> >> -- >> Thanks & Regards >> >> Santosh Math >> >> *QA Engineer* >> >> *Conflux Technologies Pvt Ltd <http://www.confluxtechnologies.com/>* >> | *Office*: +91-080-41208662 | >> >> *Address*: #304, 2nd Floor, 7th Main Road, HRBR Layout 1st Block, >> Bengaluru, Karnataka, 560043 INDIA >> > -- Thanks & Regards Santosh Math *QA Engineer* *Conflux Technologies Pvt Ltd <http://www.confluxtechnologies.com/>* | *Office*: +91-080-41208662 | *Address*: #304, 2nd Floor, 7th Main Road, HRBR Layout 1st Block, Bengaluru, Karnataka, 560043 INDIA
