Guys, I agree to create branch protection. But I don't agree saying "I broke more than fixed". I was trying to help fix those two integration issues and was preparing the Fineract 1.4.0 release. I don't see any issue with the code changes (just test data preparation) Unfortunately I didn't observe the travis CI, the actual error is below. provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/Utils.java:265: Line has trailing spaces. [RegexpSingleline]
I request Fineract board members to remove my committer rights as I won't be able to contribute to this project and in future I won't end up creating the travis problems :-) All the best Regards, Nazeer On Sun, Jan 26, 2020 at 6:04 PM Juhan Aasaru <aas...@gmail.com> wrote: > Hi Michael, > > you can create Infra ticket for adding branch protection to develop branch. > Same thing has been done for Fineract-CN repositories by this ticket: > https://issues.apache.org/jira/browse/INFRA-19492 > > Kind regards > Juhan > > Kontakt Michael Vorburger (<m...@vorburger.ch>) kirjutas kuupäeval P, 26. > jaanuar 2020 kell 12:57: > >> As far as I saw (only looked quickly), Nazeer actually accidentally broke >> more than was fixed... ;-) The "fix" for FINERACT-820 fails to pass >> Checkstyke. (Which is brand new, Nazeer see the recent post announcing it >> on this list.) >> >> BTW that commit was pushed without going through a PR. IMHO no committer >> should ever do that. (I'll try to find out if it's possible to activate >> GitHub's "protected branch" setting for 'develop', which should allow us to >> block this, when I'm back from... skiing! :) >> >> So someone should either revert that commit, or fix the Checkstyke >> problem. Personally I would just push a revert commit, and then expect a >> new PR, where we can verify the fix before merging it. >> >> M. >> >> >> >> On Sun, 26 Jan 2020, 11:11 Awasum Yannick, <awa...@apache.org> wrote: >> >>> Hi All, >>> >>> Our Fineract 1.x integration tests still failing on Sundays? >>> >>> https://issues.apache.org/jira/browse/FINERACT-820 has been closed. Has >>> the problem finally gone away? >>> >>> Is anyone willing to look into this? >>> >>> >>> On Sun, Jan 26, 2020 at 10:24 AM Travis CI <bui...@travis-ci.org> wrote: >>> >>>> apache >>>> >>>> / >>>> >>>> fineract >>>> >>>> <https://travis-ci.org/apache/fineract?utm_medium=notification&utm_source=email> >>>> >>>> [image: branch icon]develop >>>> <https://github.com/apache/fineract/tree/develop> >>>> [image: build has failed] >>>> Build #602 is still failing >>>> <https://travis-ci.org/apache/fineract/builds/641965227?utm_medium=notification&utm_source=email> >>>> [image: arrow to build time] >>>> [image: clock icon]3 mins and 38 secs >>>> >>>> [image: Awasum Yannick avatar]Awasum Yannick >>>> 7774766 CHANGESET → >>>> <https://github.com/apache/fineract/compare/e9e0bbc930de...777476624557> >>>> >>>> Update Gradle version from 5.6.1 to 6.1 >>>> >>>> Want to know about upcoming build environment updates? >>>> >>>> Would you like to stay up-to-date with the upcoming Travis CI build >>>> environment updates? We set up a mailing list for you! >>>> SIGN UP HERE <http://eepurl.com/9OCsP> >>>> >>>> [image: book icon] >>>> >>>> Documentation <https://docs.travis-ci.com/> about Travis CI >>>> Have any questions? We're here to help. <supp...@travis-ci.com> >>>> Unsubscribe >>>> <https://travis-ci.org/account/preferences/unsubscribe?repository=6979119&utm_medium=notification&utm_source=email> >>>> from build emails from the apache/fineract repository. >>>> To unsubscribe from *all* build emails, please update your settings >>>> <https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email>. >>>> >>>> [image: black and white travis ci logo] <https://travis-ci.com> >>>> >>>> Travis CI GmbH, Rigaer Str. 8, 10427 Berlin, Germany | GF/CEO: Randy >>>> Jacops | Contact: cont...@travis-ci.com | Amtsgericht Charlottenburg, >>>> Berlin, HRB 140133 B | Umsatzsteuer-ID gemäß §27 a Umsatzsteuergesetz: >>>> DE282002648 >>>> >>>
