Hi Petri Thanks for doing all this work. Its invaluable.
On Fri, May 1, 2020 at 10:24 AM Petri Tuomola <pe...@tuomola.org> wrote: > Great stuff! > > Having done some testing on this, what seems to work is: > > - bootRun starts Spring Boot embedded Tomcat and works as expected > > - bootJar creates a JAR that can be executed from command line and works > as expected > > - bootWar creates a WAR that can be deployed to an external Tomcat and > works as expected. However the WAR file can’t be started directly from > command line, as OpenJPA doesn’t seem to be able to find > persistence-enhanced classes from within a WAR (looking at the source, it > seems to be hardcoded to only handle classes from filesystem or JAR). > > What doesn’t seem to work anymore after my changes is the “other” embedded > Tomcat - i.e. version 7.0.94 - that is included directly as a dependency > in build.gradle and used for tasks tomcatRunWar / tomcatRun. I suppose > that’s not surprising as there are two embedded Tomcats bundled that are > likely to conflict, so getting both to work will require some thinking. > > To the best of my knowledge the tomcatRunWar task is used in development for quickly testing changes one makes as they solve a problem. Is it also used for integration tests? It might be Ok to just forget about this and use the "newly fixed" (PR still to be sent) bootRun Spring Boot gradle tasks. One thing you can do is run the integrationTest tasks on the commandline and see if everything passes on your local Dev machine as that may use tomcatRunWar. I dont know if anyone has an Objection to that. Either way, Send your PR so we can also test while reviewing the code. Its not a problem as we can revert if we find that disable the tomcatRunWar tasks breaks something after merging. > Before I try to find a way to get both of these to work, I wanted to check > if these are both needed? I.e. is there a reason to include two different > embedded Tomcat versions and two Gradle tasks to start them? Or would it be > possible to just remove the older version and related Gradle tasks & > plugin, and use the Spring Boot version only? > Lets use the bootRun tasks for dev purposes except someone objects. Send your PR Petri Thanks. Awasum On 30 Apr 2020, at 11:11 PM, Michael Vorburger <m...@vorburger.ch> wrote: > > Petri, > > welcome to Apache Fineract. > > Yes, a PR for this would be *VERY* welcome... ;-) > > Tx, > M. > > > On Thu, 30 Apr 2020, 22:07 Petri Tuomola, <petri.tuom...@gmail.com> wrote: > >> Hi all >> >> I’m new to Fineract - so apologies in advance for anything I may have got >> wrong with this: >> >> I had a bit of spare time today and downloaded the latest develop branch >> for Fineract 1.x. Initially it did not start on my machine - ./gradlew >> bootRun threw a lot of errors. >> >> But after a couple of fixes to dependencies, SSL config, main class etc, >> ./gradlew bootRun now seems to work fine: the application starts and I can >> call the API etc. >> >> My changes are in a branch at >> https://github.com/ptuomola/fineract/tree/FINERACT-730 and I was >> wondering if these would be of interest to anyone? >> >> I think this should help to address the issue FINERACT-730 >> >> If yes, I can open a pull request - once I’ve done some more testing >> (e.g. that the built WAR can also be started and that I haven’t broken the >> dev profile build etc) >> >> Thanks in advance >> >> Regards >> Petri >> >> >
