... I'm a little further down the rabbit hole. So, this is where things (for one of the errors at least) things start to break:
https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java#L976 ... which in turn lands us here: https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanCharge.java#L861 The function "getUnpaidInstallmentLoanCharge()" will return a null, because the collection "loanInstallmentCharge" is empty. I have to admit that I'm not entirely sure about the business logic and what should be where and when. The only thing I can say is that "loanInstallmentCharge" should contain an entry and it doesn't. Would be great if someone with a better insight into the business logic could chime in here. FYI On Tue, Mar 29, 2022 at 6:49 PM Aleksandar Vidakovic < [email protected]> wrote: > ... alright, one of the failures is due to a NPE, but additionally the > error object doesn't get populated properly. The part that should contain > valid JSON is messed up and contains this: > > {"Exception": java.lang.NullPointerException: Cannot invoke > "org.apache.fineract.portfolio.loanaccount.domain.LoanInstallmentCharge.updatePaidAmountBy(org.apache.fineract.organisation.monetary.domain.Money, > org.apache.fineract.organisation.monetary.domain.Money)" because the return > value of > "org.apache.fineract.portfolio.loanaccount.domain.LoanCharge.getUnpaidInstallmentLoanCharge()" > is null} > > ... which is obviously invalid JSON... which bubbles up at the REST > endpoint. > > So there might be 2 problems here with that one error: > - the NPE that triggers the error > - ... and that the error object is not properly populated > > Just FYI > > On Tue, Mar 29, 2022 at 6:14 PM Aleksandar Vidakovic < > [email protected]> wrote: > >> ... thanks a ton Manoj... I'm debugging too... will post if I know more. >> >> On Tue, Mar 29, 2022 at 5:53 PM Manoj VM <[email protected]> wrote: >> >>> Hi Team, >>> >>> Added a ticket to track this issue >>> https://issues.apache.org/jira/browse/FINERACT-1557 and working on the >>> same. >>> >>> Thanks and Regards, >>> Manoj >>> fynarfin.io >>> >>> >>> On Tue, Mar 29, 2022 at 1:16 PM Aleksandar Vidakovic < >>> [email protected]> wrote: >>> >>>> ... good point Arnold. Avik, Manoj: just waiting for the current build >>>> (where these tests are disabled) to pass... hope you don't mind if we >>>> revert the changes as Arnold said to unblock other PRs. >>>> >>>> If you need any help please let me know. >>>> >>>> Cheers, >>>> >>>> Aleks >>>> >>>> On Tue, Mar 29, 2022 at 9:35 AM Arnold Galovics < >>>> [email protected]> wrote: >>>> >>>>> Hi Aleks, others, >>>>> >>>>> I see we have quite some things lined up to be merged so I'm proposing >>>>> to revert the particular PR that broke the build. As soon as Manoj, Avik >>>>> is >>>>> able to fix the implementation, they can open a new PR to reapply the >>>>> changes. >>>>> >>>>> I'd say let's unblock the build as soon as possible and let other >>>>> changes come in instead of letting them pile up. >>>>> >>>>> Hope that makes sense. >>>>> Best, >>>>> Arnold >>>>> >>>>> On Tue, Mar 29, 2022 at 9:30 AM Aleksandar Vidakovic < >>>>> [email protected]> wrote: >>>>> >>>>>> Hi Manoj, Avik, >>>>>> >>>>>> ... just sending you the stacktraces (please see attachment) I could >>>>>> find for the failing tests... would be great if you could look at this... >>>>>> appreciate it. >>>>>> >>>>>> Please let me know if there's anything I can do to help. >>>>>> >>>>>> Thanks again, >>>>>> >>>>>> Aleks >>>>>> >>>>> >>> Disclaimer: >>> >>> Privileged & confidential information is contained in this message >>> (including all attachments). If you are not an intended recipient of this >>> message, please destroy this message immediately and kindly notify >>> the sender by reply e-mail. Any unauthorised use or dissemination of >>> this message in any manner whatsoever, in whole or in part, is strictly >>> prohibited. This e-mail, including all attachments hereto, (i) is for >>> discussion purposes only and shall not be deemed or construed to be a >>> professional opinion unless expressly stated otherwise, and (ii) is not >>> intended, written or sent to be used, and cannot and shall not be used, for >>> any unlawful purpose. This communication, including any attachments, may >>> not be free of viruses, interceptions or interference, and may not be >>> compatible with your systems. You should carry out your own virus checks >>> before opening any attachment to this e-mail. The sender of this e-mail and >>> *Fynarfin Tech Private Limited* shall not be liable for any damage that >>> you may sustain as a result of viruses, incompleteness of this message, a >>> delay in receipt of this message or computer problems experienced. >>> >>
