Hi all,
While going through the client module I noticed that
POST /clients/{clientId}/charges/{chargeId}?command=inactivate
has never worked. The command routes correctly through the API layer,
but no handler was registered for CLIENTCHARGE|INACTIVATE, so it
always throws UnsupportedCommandException. The service method was
also a stub returning null with a "functionality not yet supported"
comment.
I opened a PR to implement the missing handler and service logic:
https://github.com/apache/fineract/pull/5655
One thing I wanted to get feedback on before it gets reviewed -
undoPayment() and undoWaiver() on ClientCharge unconditionally set
status = true, which means undoing a prior payment on an inactivated
charge would silently reactivate it. In the PR I treated inactivation
as a terminal state and blocked undo on inactive charges.
Happy to hear if there is a different intended behavior here.
Thanks
Ashhar
