Hi, Forwarding to dev list as people there may not be subscribed. Please cc on any responses as I’m not subscribe to your dev list.
Thanks, Justin > Begin forwarded message: > > From: Justin Mclean <[email protected]> > Subject: Re: [VOTE] [FINERACT] 0.1.0.incubating for release > Date: 14 April 2016 3:42:09 pm AEST > To: [email protected] > Reply-To: [email protected] > > Hi, > > Little confusing if this is a call to vote on the incubator or not but either > way this may help. > > If it is an incubator vote I’d vote -1 (binding) due to LICENSE/NOTICE issues > and possible inclusion of Category B/Category X licensed software in a > release. > > I checked: > - Signature and hashes good (but you may want to upload your KEY to > http://hkps.pool.sks-keyservers.net) > - DISCLAIMER exists > - LICENSE has issues (see below) > - NOTICE also has issues (see below) > - Several java source files are missing headers > - There an unexpected binary file in the source release [5] > > Your mentors should be able to help out with assembling LICENSE and NOTICE. > If your’ve not done so you may want to run rat over the source release and > it’s picking up a few issues. [5] > > For the NOTICE: > - Year range is wrong replace 2014 with 2016 > - There is no need to list PD, BSD or MIT in NOTICE. Only some licenses > require you to add things to NOTICE. [1] > - Only things that are bundled need to be listed not dependancies. [2] > - There are EPL and CDDL software mentioned. This are category B and are > generally not allowed to be distributed in a source release. [3] > - There are GPL license software mentioned. There are category X and not > allowed distributed or be a dependancy of an Apache release [4] > > For the LICENSE: > - The short form (i.e. a pointer to the full text of the license) is > preferring that past the full text of long licenses in LICENSE > - Again only things that are bundled need to be listed. [2] > - Several Category B (Mozilla, CDDL, EPL) licensed items are mentioned. [3] > - The GNU license text is included! [4] > - License is missing several bundled items included jQuery, normalise, > bootstrap, moderniser, html5shiv, jszip, respond, uglify, glyph icons > halflings font, polyfill (and probably others) > > Thanks, > Justin > > 1. http://www.apache.org/dev/licensing-howto.html#mod-notice > 2. http://www.apache.org/dev/licensing-howto.html#guiding-principle > 3. http://www.apache.org/legal/resolved.html#category-b > 4. http://www.apache.org/legal/resolved.html#category-x > 5. docs/system-architecture/css/toc-0.1.2.zip > 6. http://creadur.apache.org/rat/ > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] >
