Github user pramodn02 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/63#discussion_r60219255
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/CalculateLoanScheduleQueryFromApiJsonHelper.java
---
@@ -55,9 +55,9 @@
"interestChargedFromDate", "submittedOnDate",
"submittedOnNote", "locale", "dateFormat", "charges", "collateral",
"syncDisbursementWithMeeting", "linkAccountId",
LoanApiConstants.disbursementDataParameterName,
LoanApiConstants.emiAmountParameterName,
LoanApiConstants.maxOutstandingBalanceParameterName,
- LoanProductConstants.graceOnArrearsAgeingParameterName,
LoanProductConstants.recalculationRestFrequencyDateParamName,
- "createStandingInstructionAtDisbursement",
LoanApiConstants.isFloatingInterestRateParameterName,
- LoanApiConstants.interestRateDifferentialParameterName));
+ LoanProductConstants.graceOnArrearsAgeingParameterName,
"createStandingInstructionAtDisbursement",
+ LoanApiConstants.isFloatingInterestRateParameterName,
LoanApiConstants.interestRateDifferentialParameterName,
+ "repaymentFrequencyNthDayType",
"repaymentFrequencyDayOfWeekType"));
--- End diff --
create constants in LoanApiConstants and use in all other places
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
