+1 As you'll notice from my description below, there are several weaknesses in this release, but I want us to go through the experience of voting on a release in the general incubator board, so that we can get a more complete view of what further problems we might have and start working on them. Nothing I saw was a blocker for an incubating release, but for a top-level project release, I will raise my standards.
Greets from the Voreifel, Germany, Myrle 1.) I checked NOTICE and license files. We still have that pesky hibernate problem. This may well trip us up in general incubation voting. 2.) I also built from source: I did wonder why we do not include the gradlewrapper jar in the source distribution. I followed the instructions in the gradle website ( https://docs.gradle.org/current/userguide/gradle_wrapper.html) to download the specified gradle wrapper, rather than following the instructions literally. My attempt to follow the instructions literally failed. 3.) I tried the instructions for running integration tests: I had to change my db password to mysql to get the gradle scripts to work. There's probably a better way, but I didn't bother to spend time searching. Step 4.b. failed on my first attempt. I dropped the db mifostenant-default, and tried again and it still failed. Here's the error: " FAILURE: Build failed with an exception. * Where: Build file '/home/myrle/Downloads/apache-fineract-0.1.2-incubating-src/fineract-provider/build.gradle' line: 264 * What went wrong: Execution failed for task ':flywayMigrate'. > Error occurred while executing flywayMigrate Error executing statement at line 235: call migrate_withdrwal_fees() Expression #3 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'mifostenant-default.sa.withdrawal_fee_amount' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by Expression #3 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'mifostenant-default.sa.withdrawal_fee_amount' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by " 4.) I checked the signature: I checked that the signature is valid, and did fingerprint check with Nazeer via Skype. This is not an ideal fingerprint check, but I don't know Nazeer well enough that any other method would give me any better information. *Myrle Krantz* Solutions Architect RɅĐɅЯ, The Mifos Initiative mkra...@mifos.org | Skype: mkrantz.mifos.org | http://mifos.org <http://facebook.com/mifos> <http://www.twitter.com/mifos> On Mon, May 9, 2016 at 5:59 AM, Roman Shaposhnik <ro...@shaposhnik.org> wrote: > Hi Nazeer, > > thanks for working on the release. VOTE threads on ASF releases > typically follow a particular pattern of what information they communicate > to make the voting process easier. Here's a good example: > > http://mail-archives.apache.org/mod_mbox/incubator-madlib-dev/201602.mbox/%3CCAKBQfzT6fn1Mzhs9gtEBC6m_pe=U1qzaRLF2rV5=7wpgv-s...@mail.gmail.com%3E > > Also, I would highly encourage you to start a wiki page documenting > the process of releases to make next RM's job easier. Once again, > here's a good (if only exhaustive!) example: > https://cwiki.apache.org/confluence/display/GEODE/Release+proccess > > Thanks, > Roman. > > On Fri, May 6, 2016 at 5:03 AM, Nazeer Shaik > <nazeer.sh...@confluxtechnologies.com> wrote: > > Hi all, > > > > We have resolved windows line feeds issue and prepared 0.1.2-incubating > > release for FINERACT. The files are hosted at > > > > > https://dist.apache.org/repos/dist/dev/incubator/fineract/0.1.2-incubating/ > > > > The git repository is located at > > https://github.com/apache/incubator-fineract/tree/0.1.2-incubating > > > > Again, this is source only release with no binaries, with instructions on > > how to build/test the application. > > > > I call for VOTING for this release and this voting closes by Wednesday > > (11-May-2016) evening. > > > > Thanks, > > Nazeer >
