Hi all, Can you help us whether the approach we have taken to include LGPL dependency only for integration tests is OK or not.
Thanks, Nazeer On Thu, Jul 14, 2016 at 9:46 AM, Adi Raju <adi.r...@confluxtechnologies.com> wrote: > Hello All, > > I have verified that unless *-PbuildType=TEST* param is used, none of the > gradle command includes any GPL/LGPL dependencies. > Only when you specify the *-PbuildType=TEST* that these dependencies are > downloaded and included into the war file. > > This is the approach we have taken to clearly demonstrate that LGPL > dependency is used only for test or development. > > John/Justin/Mentors, > > Thanks for helping us out here. > Do you think our intention of using LGPL only for dev or test usage and > this approach of enforcing the same thru gradle build script acceptable? > We have been going in circles over this for a long time. > Your comments and suggestions are valuable here for us. > > Regards, > Adi > > -----Original Message----- > From: Nazeer Shaik [mailto:nazeer.sh...@confluxtechnologies.com] > Sent: 14 July 2016 08:23 > Cc: d...@fineract.apache.org > Subject: Re: [VOTE] [FINERACT] 0.3.2-incubating for release > > Hi John, > > I am using *./gradlew clean war *or *./gradlew build* command to build the > binary without hibernate dependency. > and *./gradlew clean integrationTest -PbuildType=TEST* to run integration > tests with hibernate dependency. > > Distributions can be found in > *apache-fineract-0.3.2-incubating/fineract-provider/build/distributions/* > directory. > War file can be found in > *apache-fineract-0.3.2-incubating/fineract-provider/build/libs/* directory > > Thanks, > Nazeer > > > On Thu, Jul 14, 2016 at 5:24 AM, John D. Ament <johndam...@apache.org> > wrote: > > > Nazeer, > > > > Can you tell me what command you use to build? Even if its a script > > issue, I'm concerned that you're able to get a non-compliant binary > > from the source. > > > > John > > > > On 2016-07-12 23:50 (-0400), Nazeer Shaik < > > nazeer.sh...@confluxtechnologies.com> wrote: > > > Strange. Are you sure you are seeing hibernate entity manager in > binary? > > If > > > you are seeing Hibernate validator, then it is Apache Licensed. I > > > believe it wont be a problem. MySQL JDBC Driver dependency is > > > commented. So it won't download this dependency. > > > > > > Thank you very much for your time for us. Just now I have verified > > again, I > > > don't see hibernate entity manager dependency and I don't see MySQL > > > JDBC connetor is getting included in the binary. > > > > > > Nazeer > > > > > > > > > On Wed, Jul 13, 2016 at 8:53 AM, John D. Ament > > > <johndam...@apache.org> > > > wrote: > > > > > > > Hi Nazeer, > > > > > > > > I think we're disconnected a little bit. Following your readme > > > > file, I ran "gradle clean war" (Note: I have gradle preinstalled). > > > > The > > resulting > > > > binary zip includes hibernate as a dependency. In addition, I see > > > > the MySQL JDBC Driver in as a dependency, which is GPL. > > > > > > > > John > > > > > > > > On 2016-07-12 21:48 (-0400), Nazeer Shaik < > > > > nazeer.sh...@confluxtechnologies.com> wrote: > > > > > Hi John, > > > > > > > > > > We are removing hibernate transitive dependency by adding > > > > > following > > > > script > > > > > in build.gradle. > > > > > > > > > > compile() { > > > > > exclude module: 'hibernate-entitymanager' > > > > > } > > > > > > > > > > Thanks, > > > > > Nazeer > > > > > > > > > > > > > > > On Wed, Jul 13, 2016 at 7:04 AM, John D. Ament < > > johndam...@apache.org> > > > > > wrote: > > > > > > > > > > > Hi, > > > > > > > > > > > > Just to point this out - hope you don't mind my lurking. You > > > > > > still > > > > have a > > > > > > dependency on hibernate transitively from > > spring-boot-starter-data-jpa. > > > > > > > > > > > > John > > > > > > > > > > > > On 2016-07-12 10:32 (-0400), Nazeer Shaik < > > nazeer1100...@apache.org> > > > > > > wrote: > > > > > > > Hello Fineract community, > > > > > > > > > > > > > > We have created 0.3.2-incubating release, with the artifacts > > below up > > > > > > for a > > > > > > > vote. > > > > > > > > > > > > > > These are the goals of this release: > > > > > > > > > > > > > > - Moved Hibernate dependency only to integration tests. > > > > > > > So > > default > > > > > > build > > > > > > > will not include Hibernate dependency > > > > > > > - Removed JSR305 dependency > > > > > > > > > > > > > > > > > > > > > *For more information including release notes, please see:* > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/FINERACT/0.3.2+Release-+Ap > > ache+Fineract > > > > > > > > > > > > > > This is a *source code tar ball* only release. > > > > > > > > > > > > > > *** Please download, review and vote by Thu July 14, 2016 @ > > > > > > > 6pm > > PST > > > > *** > > > > > > > > > > > > > > *Source Files:* > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/fineract/0.3.2-incuba > > ting/ > > > > > > > > > > > > > > *Commit to be voted on:* > > > > > > > > > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-fineract.git;a=com > > mit;h=refs/heads/0.3.2-incubating > > > > > > > > > > > > > > *Build verification steps can be found at: * Refer > > > > > > > 'README.md' in apache-fineract-0.3.2-incubating-src.tar.gz > > > > > > > > > > > > > > *KEYS file containing PGP Keys we use to sign the release:* > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/fineract/KE > > > > > > > YS > > > > > > > > > > > > > > > > > > > > > *Note: * > > > > > > > > > > > > > > - This is a source only release with no binaries, with > > > > instructions on > > > > > > > how to build/test the application. > > > > > > > - We use hibernate for integration tests only and doesn't > > include > > > > any > > > > > > > source or binary from Hibernate > > > > > > > - There is a *change in command to run integration tests*. > > Please > > > > look > > > > > > > at README.md for more details. > > > > > > > > > > > > > > To help in tallying the vote, members please be sure to > > > > > > > indicate "(binding)" with your vote. > > > > > > > > > > > > > > [ ] +1 approve > > > > > > > [ ] +0 no opinion > > > > > > > [ ] -1 disapprove (and reason why) > > > > > > > > > > > > > > Thank you, > > > > > > > Nazeer > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
