[ 
https://issues.apache.org/jira/browse/FINERACT-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932072#comment-15932072
 ] 

ASF GitHub Bot commented on FINERACT-418:
-----------------------------------------

GitHub user lionelraymundi opened a pull request:

    https://github.com/apache/incubator-fineract/pull/319

    FINERACT-418 penalties should be applied until the day before running job

    changed diff condition to <1. Previous version made penalties to be 
calculated until the same day the job was running

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lionelraymundi/incubator-fineract FINERACT-418

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-fineract/pull/319.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #319
    
----
commit a7b27d6d363198c6017408a768d90015b047ef0c
Author: Lionel Raymundi - Poincenot <[email protected]>
Date:   2017-03-20T02:11:29Z

    FINERACT-418 penalties should be applied until the day before running job

----


> Penalties should be calculated until yesterday
> ----------------------------------------------
>
>                 Key: FINERACT-418
>                 URL: https://issues.apache.org/jira/browse/FINERACT-418
>             Project: Apache Fineract
>          Issue Type: Improvement
>          Components: Loan
>            Reporter: Lionel Raymundi
>            Assignee: Markus Geiss
>              Labels: p2
>         Attachments: tests_with_modified_penalties_calculation_process.odt, 
> tests_with_monthly_penalties.ods
>
>
> If the Apply Penalties to Overdued loans job is run on the N day, and 
> considering that system properties Grace on Penalty posting = 0 and 
> penalty-wait-period = 0, then charges should be generated until N-1 (the day 
> before N). But I see only charges generated until N-2 (Two days before).
> We have noticed that penalty charges are being generated one day late for 
> some cases. For example: 
> .- Lets suppose the due date of an installment is on march the 5th.
> .- Overdue penalty is configured as 1% of installment interest, charged daily.
> .- System configuration has Grace on Penalty posting = 0 and 
> penalty-wait-period = 0
> .- Run the Apply penalties to Overdued Loans job.
> .- Today is march the 7th, so I would expect to see penalties on that 
> installment on the repayment schedule considering the following:
> a) Client didn't pay On march 5th. One penalty charge should be generated.
> b) Client didn't pay On march 6th. Two penalty charges should be generated.
> .- I would also expect to see the charge generated with due as of date 05 and 
> 06 March 2017 under "Charges" tab. But I only see one penalty, as of 05.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to