It should be right on PR 61:
https://github.com/apache/incubator-flagon-useralejs/pull/61
I added the comment via GitHub, so if you are looking elsewhere you may
not find it.
Rob
On 3/16/2021 9:05 PM, Joshua Poore wrote:
Rob—Sorry, I was just digging into it and I didn’t see your review or feedback.
is your new handle added to apache-git? PM me if you want about this.
On Mar 16, 2021, at 10:36 AM, Rob Foley <[email protected]> wrote:
Added some feedback to the PR, looks good though. I think that there is a lot
of room for useful Cypress tests to automate what is likely a very manual
process at the moment. A bespoke branch is probably the right option (imo).
Rob
On 3/15/2021 2:01 PM, Joshua Poore wrote:
Starting new thread…
Am starting off the thread with link to some examples Gedd *just* pushed (go
Gedd)! I might be a little bit delayed in looking at this one—have to update
website for new release and do some branch management and bug hunting tonight
(and tomorrow, I expect). Austin, Rob—feel free to check out the PR.
I think we should create a new branch for Cypress exploration (at least first
couple of examples)—thoughts?
Begin forwarded message:
From: UncleGedd <[email protected]>
Subject: [apache/incubator-flagon-useralejs] adds cypress journey test (#61)
Date: March 15, 2021 at 1:05:38 PM EDT
To: apache/incubator-flagon-useralejs
<[email protected]>
Cc: Subscribed <[email protected]>
Reply-To: apache/incubator-flagon-useralejs
<reply+ac474bqej3vq7zjfg2hvpzn6ln2ofevbnhhddf4...@reply.github.com>
Adds cypress journey test
Simple example of using cypress to assert on the page load log
You can view, comment on, or merge this pull request online at:
https://github.com/apache/incubator-flagon-useralejs/pull/61
<https://github.com/apache/incubator-flagon-useralejs/pull/61>
<https://github.com/apache/incubator-flagon-useralejs/pull/61
<https://github.com/apache/incubator-flagon-useralejs/pull/61>>
Commit Summary
adds cypress journey test
File Changes
M .gitignore
<https://github.com/apache/incubator-flagon-useralejs/pull/61/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947
<https://github.com/apache/incubator-flagon-useralejs/pull/61/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947>>
(1)
M build/userale-2.1.1.min.js
<https://github.com/apache/incubator-flagon-useralejs/pull/61/files#diff-e081d0c15a971d9fd34c3c0743c5718aacbda4b86d2c6c76ba04fe3c69c7393c
<https://github.com/apache/incubator-flagon-useralejs/pull/61/files#diff-e081d0c15a971d9fd34c3c0743c5718aacbda4b86d2c6c76ba04fe3c69c7393c>>
(2)
A cypress.json
<https://github.com/apache/incubator-flagon-useralejs/pull/61/files#diff-db1f8bb89a89d5b089b39a2af3c27ab75092f1844a158eca0a76445d513d9044
<https://github.com/apache/incubator-flagon-useralejs/pull/61/files#diff-db1f8bb89a89d5b089b39a2af3c27ab75092f1844a158eca0a76445d513d9044>>
(4)
M example/index.html
<https://github.com/apache/incubator-flagon-useralejs/pull/61/files#diff-3ee232a310ee722612ee4c129240a701e053e1421356094e6de048f91db1aa2d
<https://github.com/apache/incubator-flagon-useralejs/pull/61/files#diff-3ee232a310ee722612ee4c129240a701e053e1421356094e6de048f91db1aa2d>>
(2)
A journey/userale.journey.js
<https://github.com/apache/incubator-flagon-useralejs/pull/61/files#diff-6e480e60339432e4d7545f613605a02ef54b404e248988a025d954fbe75c4caf
<https://github.com/apache/incubator-flagon-useralejs/pull/61/files#diff-6e480e60339432e4d7545f613605a02ef54b404e248988a025d954fbe75c4caf>>
(18)
M package-lock.json
<https://github.com/apache/incubator-flagon-useralejs/pull/61/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519
<https://github.com/apache/incubator-flagon-useralejs/pull/61/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519>>
(3412)
M package.json
<https://github.com/apache/incubator-flagon-useralejs/pull/61/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
<https://github.com/apache/incubator-flagon-useralejs/pull/61/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519>>
(7)
Patch Links:
https://github.com/apache/incubator-flagon-useralejs/pull/61.patch
<https://github.com/apache/incubator-flagon-useralejs/pull/61.patch><https://github.com/apache/incubator-flagon-useralejs/pull/61.patch
<https://github.com/apache/incubator-flagon-useralejs/pull/61.patch>>
https://github.com/apache/incubator-flagon-useralejs/pull/61.diff
<https://github.com/apache/incubator-flagon-useralejs/pull/61.diff>
<https://github.com/apache/incubator-flagon-useralejs/pull/61.diff
<https://github.com/apache/incubator-flagon-useralejs/pull/61.diff>>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/apache/incubator-flagon-useralejs/pull/61
<https://github.com/apache/incubator-flagon-useralejs/pull/61>>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC474BR4SM5MWZ36YXHUOYTTDY46FANCNFSM4ZG6H7BA
<https://github.com/notifications/unsubscribe-auth/AC474BR4SM5MWZ36YXHUOYTTDY46FANCNFSM4ZG6H7BA>>.
