confusingstraw commented on pull request #64: URL: https://github.com/apache/incubator-flagon-useralejs/pull/64#issuecomment-804214936
i think checking `e` isn't too egregious. it just means it is an optional argument. i do see your point though, and i am not sure where i land on the issue. i don't think we ought to add `e` to `packageCustomLog`, as that completely changes the nature of its API. i think the main question is whether the `map` handler ought to be called from within `packageCustomLog`. i'd argue yes, but i could be convinced otherwise. you don't actually _have_ to check whether `e` is passed either. you can just see if `log.logType === 'custom'`. doesn't change the argument too much though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
