GREAT WORK! but… -1 (please don’t kill me) (Binding)
Remember that initial releases are the hardest! I checked: [ X ] Build and Unit Tests Pass [ X ] Signatures and Hashes Match Keys (checked SHA 512) [ X ] LICENSE, and NOTICE Files in Source and Binary Release Packages [ X ] LICENSE, and NOTICE are consistent with ASF and Incubator Policy [ X ] CHANGELOG included with release distribution (not needed for initial release) [ - ] All Source Files Have Correct ASF Headers [ X ] No Binary Files in Source Release Packages (excluding img files) The only hard blocker for release now is the ASF headers. There are a number of src files which need licenses (see below). There are a few exclusions to this rule: 1. Binaries like image files, which can’t have headers 2. Generated files (e.g., docs files that are generated from source are excluded) 3. Configs and other types in which headers would be parsed and break stuff (i.e., .json, .bin), or headers cannot be added (e.g., .csv). Rule of thumb—if it can take a comment, it should get a header. I’m going to work on this tonight to help out on this. One question: is everything in docs/docs generated by a make process? It’ll save us some time knowing what’s source and what’s been generated by the docs build process. +++++++++++++++License Header Audit+++++++++++++++++++++++ Generated with Apache RAT: https://creadur.apache.org/rat/apache-rat/index.html Report generated with this command (note exclusions -e): % java -jar $RAT -e ".+\\.json" -e ".+\\.csv" -e ".+\\.txt" -e ".+\\.bat" -d flagon-distill Files with Apache License headers will be marked AL Binary files (which do not require any license headers) will be marked B Compressed archives will be marked A Notices, licenses etc. will be marked N AL flagon-distill/.asf.yaml AL flagon-distill/.dockerignore !????? flagon-distill/.flake8 AL flagon-distill/.gitignore !????? flagon-distill/.pre-commit-config.yaml AL flagon-distill/.readthedocs.yaml AL flagon-distill/AUTHORS.rst AL flagon-distill/CHANGELOG.md AL flagon-distill/CONTRIBUTING.rst N flagon-distill/DISCLAIMER N flagon-distill/LICENSE AL flagon-distill/MANIFEST.in !????? flagon-distill/Makefile N flagon-distill/NOTICE AL flagon-distill/README.rst !????? flagon-distill/poetry.lock !????? flagon-distill/poetry.toml AL flagon-distill/pyproject.toml !????? flagon-distill/pytest_prev_init.ini AL flagon-distill/setup.cfg AL flagon-distill/setup.py AL flagon-distill/Dashboard/app.py AL flagon-distill/Dashboard/index.py AL flagon-distill/Dashboard/assets/bootstrap.min.css AL flagon-distill/Dashboard/assets/style.css AL flagon-distill/Dashboard/pages/bar_chart.py AL flagon-distill/Dashboard/pages/bubble.py AL flagon-distill/Dashboard/pages/gantt.py AL flagon-distill/Dashboard/pages/home.py AL flagon-distill/Dashboard/pages/pie.py AL flagon-distill/Dashboard/pages/upload.py AL flagon-distill/Dashboard/pages/upload_tst.py AL flagon-distill/distill/__init__.py AL flagon-distill/distill/__version__.py AL flagon-distill/distill/analytics/__init__.py AL flagon-distill/distill/analytics/graph/README.md AL flagon-distill/distill/analytics/graph/__init__.py AL flagon-distill/distill/analytics/graph/conf.py AL flagon-distill/distill/analytics/graph/graph.py AL flagon-distill/distill/analytics/stat/__init__.py AL flagon-distill/distill/analytics/stat/stats.py AL flagon-distill/distill/process/__init__.py AL flagon-distill/distill/process/search.py AL flagon-distill/distill/process/transform.py AL flagon-distill/distill/segmentation/README.rst AL flagon-distill/distill/segmentation/__init__.py AL flagon-distill/distill/segmentation/segment.py AL flagon-distill/distill/segmentation/segmentation_error.py AL flagon-distill/distill/segmentation/segments.py AL flagon-distill/distill/utils/__init__.py AL flagon-distill/distill/utils/crud.py AL flagon-distill/docs/Combining_Segments_with_Set_Logic.rst AL flagon-distill/docs/Creating_Segments.rst AL flagon-distill/docs/Example_Usage.rst AL flagon-distill/docs/Exporting_Segments.rst AL flagon-distill/docs/Funnel_Function.rst AL flagon-distill/docs/Getting_Started.rst AL flagon-distill/docs/Graph_Index.rst AL flagon-distill/docs/Makefile AL flagon-distill/docs/Manipulating_Collections_of_Segment_Objects.rst AL flagon-distill/docs/Process.rst AL flagon-distill/docs/Process_Docs.rst AL flagon-distill/docs/Sankey_Function.rst AL flagon-distill/docs/Segmentation.rst AL flagon-distill/docs/Utilities.rst AL flagon-distill/docs/Utility_Functions.rst AL flagon-distill/docs/Writing_Segments.rst AL flagon-distill/docs/conf.py AL flagon-distill/docs/index.rst !????? flagon-distill/docs/docs/.buildinfo !????? flagon-distill/docs/docs/.buildinfo 2 !????? flagon-distill/docs/docs/Combining_Segments_with_Set_Logic.html !????? flagon-distill/docs/docs/Creating_Segments.html !????? flagon-distill/docs/docs/Example 2.html !????? flagon-distill/docs/docs/Example.html !????? flagon-distill/docs/docs/Example_Usage.html !????? flagon-distill/docs/docs/Exporting_Segments.html !????? flagon-distill/docs/docs/Funnel_Function.html !????? flagon-distill/docs/docs/Getting_Started.html !????? flagon-distill/docs/docs/Graph 2.html !????? flagon-distill/docs/docs/Graph.html !????? flagon-distill/docs/docs/Graph_Index.html !????? flagon-distill/docs/docs/Manipulating_Collections_of_Segment_Objects.html !????? flagon-distill/docs/docs/Process.html !????? flagon-distill/docs/docs/Process_Docs.html !????? flagon-distill/docs/docs/Sankey_Function.html !????? flagon-distill/docs/docs/Segmentation.html !????? flagon-distill/docs/docs/Utilities.html !????? flagon-distill/docs/docs/Utility_Functions.html !????? flagon-distill/docs/docs/Writing_Segments.html !????? flagon-distill/docs/docs/genindex 2.html !????? flagon-distill/docs/docs/genindex.html !????? flagon-distill/docs/docs/index 2.html !????? flagon-distill/docs/docs/index.html B flagon-distill/docs/docs/objects 2.inv B flagon-distill/docs/docs/objects.inv !????? flagon-distill/docs/docs/search 2.html !????? flagon-distill/docs/docs/search.html !????? flagon-distill/docs/docs/searchindex 2.js !????? flagon-distill/docs/docs/searchindex.js B flagon-distill/docs/docs/_images/Games_List.png B flagon-distill/docs/docs/_images/Gantt.png B flagon-distill/docs/docs/_images/Graph_0.png B flagon-distill/docs/docs/_images/Graph_1.png B flagon-distill/docs/docs/_images/Graph_2.png B flagon-distill/docs/docs/_images/Graph_3.png B flagon-distill/docs/docs/_images/Number_of_Logs_Bar_Chart.png B flagon-distill/docs/docs/_images/Segment_Pie_Chart.png B flagon-distill/docs/docs/_images/Segment_Timeline.png B flagon-distill/docs/docs/_images/Superset_Dashboard.png B flagon-distill/docs/docs/_images/Timeline_Graph.png B flagon-distill/docs/docs/_images/Video_Game_Filter.png B flagon-distill/docs/docs/_images/dash.mp4 !????? flagon-distill/docs/docs/_static/basic 2.css !????? flagon-distill/docs/docs/_static/basic.css !????? flagon-distill/docs/docs/_static/doctools 2.js !????? flagon-distill/docs/docs/_static/doctools.js !????? flagon-distill/docs/docs/_static/documentation_options 2.js !????? flagon-distill/docs/docs/_static/documentation_options.js B flagon-distill/docs/docs/_static/file 2.png B flagon-distill/docs/docs/_static/file.png !????? flagon-distill/docs/docs/_static/jquery 2.js !????? flagon-distill/docs/docs/_static/jquery-3.5.1 2.js !????? flagon-distill/docs/docs/_static/jquery-3.5.1.js !????? flagon-distill/docs/docs/_static/jquery.js !????? flagon-distill/docs/docs/_static/language_data.js B flagon-distill/docs/docs/_static/minus 2.png B flagon-distill/docs/docs/_static/minus.png B flagon-distill/docs/docs/_static/plus 2.png B flagon-distill/docs/docs/_static/plus.png !????? flagon-distill/docs/docs/_static/pygments 2.css !????? flagon-distill/docs/docs/_static/pygments.css !????? flagon-distill/docs/docs/_static/searchtools.js !????? flagon-distill/docs/docs/_static/underscore-1.12.0 2.js !????? flagon-distill/docs/docs/_static/underscore-1.12.0.js !????? flagon-distill/docs/docs/_static/underscore.js !????? flagon-distill/docs/docs/_static/css/badge_only 2.css !????? flagon-distill/docs/docs/_static/css/badge_only.css !????? flagon-distill/docs/docs/_static/css/theme 2.css !????? flagon-distill/docs/docs/_static/css/theme.css B flagon-distill/docs/docs/_static/css/fonts/Roboto-Slab-Bold.woff B flagon-distill/docs/docs/_static/css/fonts/Roboto-Slab-Bold.woff2 B flagon-distill/docs/docs/_static/css/fonts/Roboto-Slab-Regular.woff B flagon-distill/docs/docs/_static/css/fonts/Roboto-Slab-Regular.woff2 B flagon-distill/docs/docs/_static/css/fonts/fontawesome-webfont.eot !????? flagon-distill/docs/docs/_static/css/fonts/fontawesome-webfont.svg B flagon-distill/docs/docs/_static/css/fonts/fontawesome-webfont.ttf B flagon-distill/docs/docs/_static/css/fonts/fontawesome-webfont.woff B flagon-distill/docs/docs/_static/css/fonts/fontawesome-webfont.woff2 B flagon-distill/docs/docs/_static/css/fonts/lato-bold-italic.woff B flagon-distill/docs/docs/_static/css/fonts/lato-bold-italic.woff2 B flagon-distill/docs/docs/_static/css/fonts/lato-bold.woff B flagon-distill/docs/docs/_static/css/fonts/lato-bold.woff2 B flagon-distill/docs/docs/_static/css/fonts/lato-normal-italic.woff B flagon-distill/docs/docs/_static/css/fonts/lato-normal-italic.woff2 B flagon-distill/docs/docs/_static/css/fonts/lato-normal.woff B flagon-distill/docs/docs/_static/css/fonts/lato-normal.woff2 !????? flagon-distill/docs/docs/_static/dark_mode_css/custom.css !????? flagon-distill/docs/docs/_static/dark_mode_css/dark.css !????? flagon-distill/docs/docs/_static/dark_mode_css/general.css !????? flagon-distill/docs/docs/_static/dark_mode_js/default_dark.js !????? flagon-distill/docs/docs/_static/dark_mode_js/default_light.js !????? flagon-distill/docs/docs/_static/dark_mode_js/theme_switcher.js !????? flagon-distill/docs/docs/_static/js/badge_only.js !????? flagon-distill/docs/docs/_static/js/html5shiv-printshiv.min.js !????? flagon-distill/docs/docs/_static/js/html5shiv.min.js !????? flagon-distill/docs/docs/_static/js/theme.js B flagon-distill/docs/docs/doctrees/Example.doctree B flagon-distill/docs/docs/doctrees/Graph.doctree B flagon-distill/docs/docs/doctrees/environment.pickle B flagon-distill/docs/docs/doctrees/index copy.doctree B flagon-distill/docs/docs/doctrees/index.doctree !????? flagon-distill/docs/docs/html/.buildinfo !????? flagon-distill/docs/docs/html/.nojekyll !????? flagon-distill/docs/docs/html/Example.html !????? flagon-distill/docs/docs/html/Graph.html !????? flagon-distill/docs/docs/html/genindex.html !????? flagon-distill/docs/docs/html/index copy.html !????? flagon-distill/docs/docs/html/index.html B flagon-distill/docs/docs/html/objects.inv !????? flagon-distill/docs/docs/html/search.html !????? flagon-distill/docs/docs/html/searchindex.js !????? flagon-distill/docs/docs/html/_static/alabaster.css !????? flagon-distill/docs/docs/html/_static/basic.css !????? flagon-distill/docs/docs/html/_static/custom.css !????? flagon-distill/docs/docs/html/_static/doctools.js !????? flagon-distill/docs/docs/html/_static/documentation_options.js B flagon-distill/docs/docs/html/_static/file.png !????? flagon-distill/docs/docs/html/_static/jquery-3.5.1.js !????? flagon-distill/docs/docs/html/_static/jquery.js !????? flagon-distill/docs/docs/html/_static/language_data.js B flagon-distill/docs/docs/html/_static/minus.png B flagon-distill/docs/docs/html/_static/plus.png !????? flagon-distill/docs/docs/html/_static/pygments.css !????? flagon-distill/docs/docs/html/_static/searchtools.js !????? flagon-distill/docs/docs/html/_static/underscore-1.12.0.js !????? flagon-distill/docs/docs/html/_static/underscore.js !????? flagon-distill/docs/docs/html/_static/css/badge_only.css !????? flagon-distill/docs/docs/html/_static/css/theme.css B flagon-distill/docs/docs/html/_static/css/fonts/Roboto-Slab-Bold.woff B flagon-distill/docs/docs/html/_static/css/fonts/Roboto-Slab-Bold.woff2 B flagon-distill/docs/docs/html/_static/css/fonts/Roboto-Slab-Regular.woff B flagon-distill/docs/docs/html/_static/css/fonts/Roboto-Slab-Regular.woff2 B flagon-distill/docs/docs/html/_static/css/fonts/fontawesome-webfont.eot !????? flagon-distill/docs/docs/html/_static/css/fonts/fontawesome-webfont.svg B flagon-distill/docs/docs/html/_static/css/fonts/fontawesome-webfont.ttf B flagon-distill/docs/docs/html/_static/css/fonts/fontawesome-webfont.woff B flagon-distill/docs/docs/html/_static/css/fonts/fontawesome-webfont.woff2 B flagon-distill/docs/docs/html/_static/css/fonts/lato-bold-italic.woff B flagon-distill/docs/docs/html/_static/css/fonts/lato-bold-italic.woff2 B flagon-distill/docs/docs/html/_static/css/fonts/lato-bold.woff B flagon-distill/docs/docs/html/_static/css/fonts/lato-bold.woff2 B flagon-distill/docs/docs/html/_static/css/fonts/lato-normal-italic.woff B flagon-distill/docs/docs/html/_static/css/fonts/lato-normal-italic.woff2 B flagon-distill/docs/docs/html/_static/css/fonts/lato-normal.woff B flagon-distill/docs/docs/html/_static/css/fonts/lato-normal.woff2 !????? flagon-distill/docs/docs/html/_static/dark_mode_css/custom.css !????? flagon-distill/docs/docs/html/_static/dark_mode_css/dark.css !????? flagon-distill/docs/docs/html/_static/dark_mode_css/general.css !????? flagon-distill/docs/docs/html/_static/dark_mode_js/default_dark.js !????? flagon-distill/docs/docs/html/_static/dark_mode_js/default_light.js !????? flagon-distill/docs/docs/html/_static/dark_mode_js/theme_switcher.js !????? flagon-distill/docs/docs/html/_static/js/badge_only.js !????? flagon-distill/docs/docs/html/_static/js/html5shiv-printshiv.min.js !????? flagon-distill/docs/docs/html/_static/js/html5shiv.min.js !????? flagon-distill/docs/docs/html/_static/js/theme.js B flagon-distill/docs/images/Games_List.png B flagon-distill/docs/images/Gantt.png B flagon-distill/docs/images/Graph_0.png B flagon-distill/docs/images/Graph_1.png B flagon-distill/docs/images/Graph_2.png B flagon-distill/docs/images/Graph_3.png B flagon-distill/docs/images/Number_of_Logs_Bar_Chart.png B flagon-distill/docs/images/Segment_Pie_Chart.png B flagon-distill/docs/images/Segment_Timeline.png B flagon-distill/docs/images/Superset_Dashboard.png B flagon-distill/docs/images/Timeline_Graph.png B flagon-distill/docs/images/Video_Game_Filter.png B flagon-distill/docs/images/dash.mp4 !????? flagon-distill/examples/Distill_Workflow_Example.ipynb !????? flagon-distill/examples/Segments_Demo.ipynb !????? flagon-distill/examples/SuperSet_ElasticDSL_Demo.ipynb AL flagon-distill/examples/TestPipeline.ipynb AL flagon-distill/github/workflows/main.yml AL flagon-distill/tests/README.rst !????? flagon-distill/tests/__init__.py !????? flagon-distill/tests/data_config.py AL flagon-distill/tests/test_graph.py AL flagon-distill/tests/test_search.py AL flagon-distill/tests/test_segment.py AL flagon-distill/tests/test_segments.py AL flagon-distill/tests/test_transform.py AL flagon-distill/tests/test_utils.py AL flagon-distill/tests/testing_utils.py > On Oct 12, 2023, at 12:20 AM, Amir Ghaemi <agha...@umd.edu> wrote: > > Hi all, > > Great work! +1 from me. > > [✓] Build and Unit Tests Pass (On Windows - Python 3.10) > [✓] DISCLAIMER, LICENSE, and NOTICE Files in Source and Binary Release > Packages > [✓] DISCLAIMER, LICENSE, and NOTICE are consistent with ASF and Incubator > Policy > [✓] All Source Files Have Correct ASF Headers > [ ] No Binary Files in Source Release Packages > [ ] Signatures and Hashes Match Keys > [ ] CHANGELOG included with release distribution > > Best, > *Amir M. Ghaemi* > > > > On Wed, Oct 11, 2023 at 1:01 PM Evan Jones <evan.a.jon...@gmail.com> wrote: > >> Hi all, >> >> Great work on delivering this baby into the world. >> >> Vote: +1 >> Checks: >> >> - Build and unit tests pass >> - DISCLAIMER, LICENSE, and NOTICE Files in Source and Binary Release >> Packages >> - DISCLAIMER, LICENSE, and NOTICE are consistent with ASF and Incubator >> Policy >> - CHANGELOG included with release distribution >> - All Source Files Have Correct ASF Headers >> >> Best >> >> Evan Jones >> Website: www.ea-jones.com >> >> >> On Tue, Oct 10, 2023 at 4:12 PM proton_mail_bridge < >> jason_...@protonmail.com> >> wrote: >> >>> Hi Folks, >>> >>> Let’s try this again, please VOTE on the Apache Flagon Distill 0.1.0 >>> Release Candidate #02. >>> About Flagon: http://flagon.incubator.apache.org/ >>> This is the first Beta release. >>> >>> Git source tag (0.1.0-rc02): >>> https://github.com/apache/flagon-distill/releases/tag/0.1.0-rc02 >>> >>> Staging repo: https://dist.apache.org/repos/dist/dev/flagon/ >>> Source Release Artifacts: >>> >> https://dist.apache.org/repos/dist/dev/flagon/apache-flagon-distill-0.1.0-RC-02/ >>> PGP release keys: https://dist.apache.org/repos/dist/dev/flagon/KEYS >>> Successful Github Actions Build and Tests: >>> https://github.com/apache/flagon-distill/actions/runs/6471907570 >>> PyPi Test Repo: https://test.pypi.org/project/flagon-distill/0.1.0rc2/ >>> >>> Vote will be open for 72 hours. >>> Please VOTE as follows: >>> [ ] +1, let's get it released!!! >>> [ ]+/-0, fine, but consider to fix few issues before… >>> [ ] -1, nope, because... (and please explain why) >>> >>> Along with your VOTE, please indicate testing and checks you've made >>> against build artifacts, src, and documentation: >>> [ ] Build and Unit Tests Pass >>> [ ] Signatures and Hashes Match Keys >>> [ ] DISCLAIMER, LICENSE, and NOTICE Files in Source and Binary Release >>> Packages >>> [ ] DISCLAIMER, LICENSE, and NOTICE are consistent with ASF and Incubator >>> Policy >>> [ ] CHANGELOG included with release distribution >>> [ ] All Source Files Have Correct ASF Headers >>> [ ] No Binary Files in Source Release Packages >>> >>> Thank you to everyone that is able to VOTE as well as everyone that >>> contributed to Apache Flagon Distill 0.1.0! >>> >>
