Let's close this vote. I am initiating a new one since I had to modify source (KEYS, etc.) to build a new release candidate.
Best Evan Jones Website: www.ea-jones.com On Thu, Mar 21, 2024 at 9:31 AM Joshua Poore <poor...@me.com.invalid> wrote: > I wanted to note something here, I should have said yesterday: > > You will need to restart the VOTE if you modify source—when you mod src, > youre voting on a different commit head. > > That being said, you don’t necessarily need a new thread if your just > repackaging artifacts on dist—all your blockers are there, not source. PPL > can change their votes. > > New VOTE is cleaner, though. > > > Joshua Poore > > > > On Mar 20, 2024, at 8:30 PM, Joshua Poore <poor...@apache.org> wrote: > > > > Great work folks! Really! Very close… but: > > > > Currently I’m -1 on this. I see two blocking issues on this, which must > be addressed. But, the release is very close. See below for an easy get > well plan. > > > > Issues: > > > > 1. (blocking issue) source distribution (at dist/dev) does not contain > all source files. Source files are generally a 1:1 reflection of our entire > source repo. This release artifact would also not be consistent with the > release as posted on GitHub and NPM. > > > > 2. (blocking issue) src.zip ans src.tar.gz SHA 512 don’t match published > checksums ( > https://dist.apache.org/repos/dist/dev/flagon/apache-flagon-useralejs-2.4.0-RC-01/). > I used 'shasum -a 512 [filepath]’. Checksums MUST match. > > > > 3. (non-blocking issue) Changelog entry should reflect date the release > was packaged (currently it’s blank). We cannot modify releases after the > VOTE, as this would change the commit we’re VOTING on. > > > > 4. (non-blocking issue) should update copyright year in NOTICE files. > Can get this on master after the fact with little impact. > > > > Good Stuff: > > > > 1. tests beautifully, both at unit and integration. I really like these > new features. > > 2. src and bin policies are consistent with ASF licensing policies > > > > Other (minor) notes: > > > > 1. DISCLAIMER is no longer required for us that’s a requirement of > incubating projects (no need to check for) > > 2. Should publish the Git source commit hash (you reference the Git > tag—I get it, but good practice to just provide a direct link to that > commit link in addition to the tag). > > > > Get well plan for SRC distribution and checksums: > > > > Try these bash scripts: > https://github.com/apache/flagon/tree/master/release > > > > Documentation for how to use this utility is here: > https://cwiki.apache.org/confluence/display/FLAGON/UserALE.js+Release+Management+Procedure > > > > This script will simply create a fully compliant set of release > artifacts, including checksums. These can then be directly copied to > dist/dev for the VOTE process. I promise this will greatly streamline this > process for you. > > > > Don’t hesitate to ask me if you have any questions about using the > utility. > > > > I checked: > > > > [ X ] Build and Unit Tests Pass > > [ X ] Integration Tests Pass > > [ X ] Signatures and Hashes Match Keys > > [ X ] LICENSE, and NOTICE Files in Source and Binary Release Packages > > [ X ] DISCLAIMER, LICENSE, and NOTICE are consistent with ASF and > Incubator Policy > > [ X ] CHANGELOG included with release distribution > > [ X ] All Source Files Have Correct ASF Headers > > [ X ] No Binary Files in Source Release Packages > > > > Again, great work and really close. I can’t +1 until the blocking issues > are addressed. > > > > Best, > > > > Josh > > > >> On Mar 20, 2024, at 12:25 PM, Amir Ghaemi <agha...@umd.edu> wrote: > >> > >> Thank you, Jason. > >> > >> Definitely a +1 from me! > >> > >> > >> [✓] Build and Unit Tests Pass > >> [ ] Integration Tests Pass > >> [ ] Signatures and Hashes Match Keys > >> [✓] DISCLAIMER, LICENSE, and NOTICE Files in Source and Binary Release > >> Packages > >> [✓] DISCLAIMER, LICENSE, and NOTICE are consistent with ASF and > Incubator > >> Policy > >> [✓] CHANGELOG included with release distribution > >> [✓] All Source Files Have Correct ASF Headers > >> [ ] No Binary Files in Source Release Packages > >> > >> Thanks, > >> *Amir M. Ghaemi* > >> > >> > >>> On Wed, Mar 20, 2024 at 11:01 AM Evan Jones <evan.a.jon...@gmail.com> > wrote: > >>> > >>> Yes, I see you just fixed it. > >>> > >>> +1 from me now. > >>> > >>> Best > >>> > >>> Evan Jones > >>> Website: www.ea-jones.com > >>> > >>> > >>>> On Wed, Mar 20, 2024 at 10:51 AM Jason Young <j...@apache.org> wrote: > >>> > >>>> Are you referring to the closed tickets URL on line 8 of > `CHANGELOG.md`, > >>>> or something else? > >>>> > >>>> On 2024/03/19 23:59:36 Evan Jones wrote: > >>>>> Thanks for queuing this up Jason! > >>>>> > >>>>> I'm a +0. There's one minor thing we should update: In `CHANGELOG.md` > >>> the > >>>>> most recent release still states Flagon is incubating. Did we not > >>>> graduate? > >>>>> If so, we should drop this language from releases going forward. > >>>>> > >>>>> [x] Build and Unit Tests Pass > >>>>> [x] Integration Tests Pass > >>>>> [x] Signatures and Hashes Match Keys > >>>>> [x] DISCLAIMER, LICENSE, and NOTICE Files in Source and Binary > Release > >>>>> Packages > >>>>> [x] DISCLAIMER, LICENSE, and NOTICE are consistent with ASF and > >>> Incubator > >>>>> Policy > >>>>> [x] CHANGELOG included with release distribution > >>>>> [x] All Source Files Have Correct ASF Headers > >>>>> [ ] No Binary Files in Source Release Packages > >>>>> > >>>>> Best > >>>>> > >>>>> Evan Jones > >>>>> Website: www.ea-jones.com > >>>>> > >>>>> > >>>>> On Tue, Mar 19, 2024 at 4:45 PM Jason Young <j...@apache.org> wrote: > >>>>> > >>>>>> Hi Folks, > >>>>>> > >>>>>> Please VOTE on the Apache Flagon 2.4.0 Release Candidate #01. > >>>>>> > >>>>>> About Flagon: https://flagon.apache.org/ > >>>>>> > >>>>>> This Minor release includes : > >>>>>> * Refactors Map and Filter APIs as generalized callbacks for > >>>>>> functionality > >>>>>> * Updates packages and dependencies > >>>>>> * Adds additional examples (callback functions) > >>>>>> * Updates to update deprecated downstream dev dependencies > >>>>>> * Changes to documentation, updated examples > >>>>>> * New browser extension setting, password, for basic auth. > >>>>>> * New log fields httpSessionId and browserSessionId > >>>>>> * Callbacks for auth headers and custom headers. > >>>>>> * Example json schema added. > >>>>>> > >>>>>> Git source tag (2.4.0-03_19_2024-rc01): > >>>>>> > >>>> > >>> > https://github.com/apache/flagon-useralejs/releases/tag/2.4.0-03_19_2024-rc01 > >>>>>> > >>>>>> Staging repo: https://dist.apache.org/repos/dist/dev/flagon/ > >>>>>> > >>>>>> Source Release Artifacts: > >>>>>> > >>>> > >>> > https://dist.apache.org/repos/dist/dev/flagon/apache-flagon-useralejs-2.4.0-RC-01/ > >>>>>> > >>>>>> PGP release keys: > >>>>>> https://dist.apache.org/repos/dist/release/incubator/flagon/KEYS > >>>>>> > >>>>>> Successful Github action tests: > >>>>>> https://github.com/apache/flagon-useralejs/actions/runs/8348961912 > >>>>>> > >>>>>> Vote will be open for 72 hours. Please VOTE as follows: > >>>>>> > >>>>>> [ ] +1, let's get it released!!! > >>>>>> [ ] +/-0, fine, but consider to fix few issues before... > >>>>>> [ ] -1, nope, because... (and please explain why) > >>>>>> > >>>>>> Along with your VOTE, please indicate testing and checks you've made > >>>>>> against build artifacts, src, and documentation: > >>>>>> > >>>>>> [ ] Build and Unit Tests Pass > >>>>>> [ ] Integration Tests Pass > >>>>>> [ ] Signatures and Hashes Match Keys > >>>>>> [ ] DISCLAIMER, LICENSE, and NOTICE Files in Source and Binary > >>> Release > >>>>>> Packages > >>>>>> [ ] DISCLAIMER, LICENSE, and NOTICE are consistent with ASF and > >>>> Incubator > >>>>>> Policy > >>>>>> [ ] CHANGELOG included with release distribution > >>>>>> [ ] All Source Files Have Correct ASF Headers > >>>>>> [ ] No Binary Files in Source Release Packages > >>>>>> > >>>>>> Thank you to everyone that is able to VOTE as well as everyone that > >>>>>> contributed to Apache Flagon 2.4.0 > >>>>>> > >>>>>> - Jason Young > >>>>>> > >>>>> > >>>> > >>> > > >
