"boolean escaped" is never read, so i commented it out to open a discussion about the purpose of this variable. Syntactically the variable seems to be unnecessary.
Sorry for mixing things up, will do a separate commit in the future for every discussion point or fix. (In the above commit i also renamed a method and fixed a trivial typo) Is it (in general) ok to post github commit proposals and discuss these before i create jira tickets/patches? Thanks Hendrik On Sun, Jun 29, 2014 at 12:00 AM, Romain Manni-Bucau <[email protected]> wrote: > Same as the other thread, do you care creating a patch and attaching to a > jira? > > BTW you removed boolean escaped = false;, I guess cause of your other > patch. Would be great to not mix them ;) > > > Romain Manni-Bucau > Twitter: @rmannibucau > Blog: http://rmannibucau.wordpress.com/ > LinkedIn: http://fr.linkedin.com/in/rmannibucau > Github: https://github.com/rmannibucau > > > 2014-06-28 23:25 GMT+02:00 Hendrik Dev <[email protected]>: >> isIntegralNumber() also have to throw a IllegalStateException >> >> isIntegralNumber() does now throw ise, little renaming, cleanup of >> possibly unnecessary code >> https://github.com/salyh/fleece_tmp/commit/0a06c65d7934354cb1ed9873a47159030049df68 >> >> Thanks >> Hendrik
