[
https://issues.apache.org/jira/browse/FLEECE-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053178#comment-14053178
]
Romain Manni-Bucau edited comment on FLEECE-4 at 7/6/14 7:01 PM:
-----------------------------------------------------------------
Hmm
should the tests pass now?
{code}
Results :
Failed tests: fail10(org.apache.fleece.core.JsonParserTest): Expected
exception: javax.json.stream.JsonParsingException
fail15(org.apache.fleece.core.JsonParserTest): Expected exception:
javax.json.stream.JsonParsingException
fail17(org.apache.fleece.core.JsonParserTest): Expected exception:
javax.json.stream.JsonParsingException
fail18(org.apache.fleece.core.JsonParserTest): Expected exception:
javax.json.stream.JsonParsingException
fail20(org.apache.fleece.core.JsonParserTest): Expected exception:
javax.json.stream.JsonParsingException
fail23(org.apache.fleece.core.JsonParserTest): Expected exception:
javax.json.stream.JsonParsingException
fail25(org.apache.fleece.core.JsonParserTest): Expected exception:
javax.json.stream.JsonParsingException
fail1(org.apache.fleece.core.JsonParserTest): Expected exception:
javax.json.stream.JsonParsingException
fail3(org.apache.fleece.core.JsonParserTest): Expected exception:
javax.json.stream.JsonParsingException
fail4(org.apache.fleece.core.JsonParserTest): Expected exception:
javax.json.stream.JsonParsingException
fail5(org.apache.fleece.core.JsonParserTest): Expected exception:
javax.json.stream.JsonParsingException
fail8(org.apache.fleece.core.JsonParserTest): Expected exception:
javax.json.stream.JsonParsingException
escaping(org.apache.fleece.core.JsonParserTest): expected:<[\]> but was:<[]>
emptyZeroCharBuffersize(org.apache.fleece.core.JsonReaderImplTest): Expected
exception: java.lang.IllegalArgumentException
unicode(org.apache.fleece.core.JsonReaderImplTest): expected:<[敥]> but
was:<[u6565]>
stringescapeVariousBufferSizes(org.apache.fleece.core.JsonReaderImplTest):
expected:<s"mi[t]"> but was:<s"mi[ ]">
Tests in error:
fail21(org.apache.fleece.core.JsonParserTest): Unexpected exception,
expected<javax.json.stream.JsonParsingException> but
was<java.lang.NumberFormatException>
fail7(org.apache.fleece.core.JsonParserTest): Unexpected exception,
expected<javax.json.stream.JsonParsingException> but
was<java.lang.NumberFormatException>
parseHuge1MbJsonFile(org.apache.fleece.core.JsonReaderImplTest): For input
string: ""
parseLarge130KbJsonFile(org.apache.fleece.core.JsonReaderImplTest): For input
string: ""
parseBig600KbJsonFile(org.apache.fleece.core.JsonReaderImplTest): expecting
end of structure or comma but got d
Tests run: 73, Failures: 16, Errors: 5, Skipped: 0
{code}
I think these tests show the overflow issue you spoke about but we can't push
them until it is not fixed.
You can add the patch to use your streamers here (think they solve it). I
propose to keep BufferCache with a ThreadLocal in your implementation to solve
this jira and open FLEECE-5 to see how to not force the use of a ThreadLocal.
wdyt?
was (Author: romain.manni-bucau):
Hmm
should the tests pass now?
{code}
Results :
Failed tests: fail10(org.apache.fleece.core.JsonParserTest): Expected
exception: javax.json.stream.JsonParsingException
fail15(org.apache.fleece.core.JsonParserTest): Expected exception:
javax.json.stream.JsonParsingException
fail17(org.apache.fleece.core.JsonParserTest): Expected exception:
javax.json.stream.JsonParsingException
fail18(org.apache.fleece.core.JsonParserTest): Expected exception:
javax.json.stream.JsonParsingException
fail20(org.apache.fleece.core.JsonParserTest): Expected exception:
javax.json.stream.JsonParsingException
fail23(org.apache.fleece.core.JsonParserTest): Expected exception:
javax.json.stream.JsonParsingException
fail25(org.apache.fleece.core.JsonParserTest): Expected exception:
javax.json.stream.JsonParsingException
fail1(org.apache.fleece.core.JsonParserTest): Expected exception:
javax.json.stream.JsonParsingException
fail3(org.apache.fleece.core.JsonParserTest): Expected exception:
javax.json.stream.JsonParsingException
fail4(org.apache.fleece.core.JsonParserTest): Expected exception:
javax.json.stream.JsonParsingException
fail5(org.apache.fleece.core.JsonParserTest): Expected exception:
javax.json.stream.JsonParsingException
fail8(org.apache.fleece.core.JsonParserTest): Expected exception:
javax.json.stream.JsonParsingException
escaping(org.apache.fleece.core.JsonParserTest): expected:<[\]> but was:<[]>
emptyZeroCharBuffersize(org.apache.fleece.core.JsonReaderImplTest): Expected
exception: java.lang.IllegalArgumentException
unicode(org.apache.fleece.core.JsonReaderImplTest): expected:<[敥]> but
was:<[u6565]>
stringescapeVariousBufferSizes(org.apache.fleece.core.JsonReaderImplTest):
expected:<s"mi[t]"> but was:<s"mi[ ]">
Tests in error:
fail21(org.apache.fleece.core.JsonParserTest): Unexpected exception,
expected<javax.json.stream.JsonParsingException> but
was<java.lang.NumberFormatException>
fail7(org.apache.fleece.core.JsonParserTest): Unexpected exception,
expected<javax.json.stream.JsonParsingException> but
was<java.lang.NumberFormatException>
parseHuge1MbJsonFile(org.apache.fleece.core.JsonReaderImplTest): For input
string: ""
parseLarge130KbJsonFile(org.apache.fleece.core.JsonReaderImplTest): For input
string: ""
parseBig600KbJsonFile(org.apache.fleece.core.JsonReaderImplTest): expecting
end of structure or comma but got d
Tests run: 73, Failures: 16, Errors: 5, Skipped: 0
{code}
> Add/Modify JSON test and benchmarking files
> -------------------------------------------
>
> Key: FLEECE-4
> URL: https://issues.apache.org/jira/browse/FLEECE-4
> Project: Fleece
> Issue Type: Test
> Reporter: Hendrik Saly
> Priority: Minor
> Attachments: 0001-Add-Modify-JSON-test-and-benchmarking-files.patch,
> 0002-Adapted-test-classes-for-the-new-files.patch
>
>
> Add/Modify JSON test files which (hopefully) can prove correct parsing
> behaviour. Consists of positive and negative test files. The larger files can
> also be used for benchmarking.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
