I haven't changed anything, I was asking IF changing it was a bad idea... I did however remove those two methods, as they were empty and unused. Maybe we should comment when we add some types of abstract methods that is only meant to be overridden. I'm not that familiar with Java, but I think there are ways to achieve that, correct?
I'll be a bit more conservative in the future, but as we're working on this code now with more than one person, it might be beneficial if we make our (future) intentions clear? EdB On Tue, Feb 12, 2013 at 7:37 PM, Michael Schmalle <apa...@teotigraphix.com> wrote: > Hi Erik, > > Yes, this was a bad move. The way the TestBase was setup was testing 'unit's > of code, thus we are using a simple setup for config and a simple AST syntax > request to get a FileNode. > > You need to change it back, what you changed it to is a 'functional' test. > We are not testing functionality of the compiler. > > By doing what you did, you introduced variance to the tests. The way the > TestBase was setup was a very simple load, parse, return the node. > > Also, I don't think you didn't an SVN update did you? I added two methods > that allowed the sub classes to added libraries and source paths to the > configuration. addLibraries(), addSourcePath() > > Can you please revert? > > Thanks, > Mike > > > > Quoting Erik de Bruin <e...@ixsoftware.nl>: > >> Hi Mike (I guess ;-)), >> >> I was poking around the FalconJx unit tests to set up the testing of >> projects (tests made up of more than one (generated) file), and I >> noticed that the tests "roll their own" implementation of the >> compilation process. It's generally the same, but some differences >> exist. While trying to get the project testing going, I thought I'd >> refactor MXMLJSC in such a way that it can be used for unit testing as >> well. I thought this might increase the reliability of the unit tests, >> as they would always test the compilation implementation that is >> actually used by FalconJx. Is that a really bad idea? >> >> EdB >> >> >> >> -- >> Ix Multimedia Software >> >> Jan Luykenstraat 27 >> 3521 VB Utrecht >> >> T. 06-51952295 >> I. www.ixsoftware.nl >> > > -- > Michael Schmalle - Teoti Graphix, LLC > http://www.teotigraphix.com > http://blog.teotigraphix.com > -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
