Mike, Do we introduce "new" strings, or do we reference existing ones from ASTNodeID, IASKeywordConstants, IASLanguageConstants etc.?
EdB On Mon, Feb 18, 2013 at 3:03 PM, Michael Schmalle <apa...@teotigraphix.com> wrote: > Hope everything is OK. > > Just get better, don't worry about it. :) > > I changed a couple things with the writeToken(), the main thing is getting > ASTokens fully implemented and using that. > > It feels like it should be an enum but, maybe was can make an enum based off > that interface's strings down the road. > > Mike > > > Quoting Erik de Bruin <e...@ixsoftware.nl>: > >> Mike, >> >> Just returned from the hospital, nothing big, but it is taking a >> couple of days to get my brain back up to speed after the anesthesia >> and painkillers. >> >> I will take the "re-tokenization" of the emitters on in the next couple of >> days. >> >> EdB >> >> >> >> On Fri, Feb 15, 2013 at 11:46 AM, Michael Schmalle >> <apa...@teotigraphix.com> wrote: >>> >>> >>> Erik, >>> >>> Just wanted to run this by you but I wanted to do this awhile ago, the >>> writeToken() method's original intention was to pass the token to write >>> and >>> automatically append a space AFTER the token. >>> >>> So writeToken(ASTokens.SET); >>> >>> Will produce; >>> >>> 'set ' >>> >>> This way when ever we have a token, the rule is tokens Always have a >>> space >>> to the right. This will eliminate a hug amount of code and make things >>> more >>> readable. >>> >>> >>> Since we put it in some places, before this change happens either you or >>> I >>> have to do all of it and make sure the tests pass because whitespace will >>> get changed on the writeToken() calls right now. >>> >>> I'm thinking ASTokens should be an enum and we pass the enum to >>> writeToken() >>> for type safety. What do you think? >>> >>> Mike >>> >>> >>> >>> -- >>> Michael Schmalle - Teoti Graphix, LLC >>> http://www.teotigraphix.com >>> http://blog.teotigraphix.com >>> >> >> >> >> -- >> Ix Multimedia Software >> >> Jan Luykenstraat 27 >> 3521 VB Utrecht >> >> T. 06-51952295 >> I. www.ixsoftware.nl >> > > -- > Michael Schmalle - Teoti Graphix, LLC > http://www.teotigraphix.com > http://blog.teotigraphix.com > -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
