On Fri, Apr 26, 2013 at 4:48 PM, Alex Harui <aha...@adobe.com> wrote:
> I just sent an email from my adobe.com account to commits@. > > I got back a rejection that it had to come from my apache.org address. > > That explains it. I sent an email as my apache.org address, but from an alias like how GitHub sends the emails. I also got a rejection notification. Greg, any chance you can use your moderator super powers to help this situation? Thanks, Om > > On 4/26/13 4:15 PM, "OmPrakash Muppirala" <bigosma...@gmail.com> wrote: > > > On Fri, Apr 26, 2013 at 4:07 PM, Greg Reddin <gred...@gmail.com> wrote: > > > >> I haven't seen any mod requests yet. I'm traveling this weekend and will > >> have limited network access. I will try to look into it again next week > if > >> I don't see anything before. > >> > >> Sent from my mobile device. > >> > >> > > It should have appeared. Could the list be filtering it before you get a > > chance to moderate it? Maybe you could add notificati...@github.com to > the > > safe sender list before I try again? Notifications sent to my personal > > email id works fine. > > > > Anything else I could be missing? > > > > Thanks, > > Om > > > > > >> On Apr 26, 2013, at 4:42 PM, OmPrakash Muppirala <bigosma...@gmail.com > > > >> wrote: > >> > >>> On Fri, Apr 26, 2013 at 2:26 PM, OmPrakash Muppirala > >>> <bigosma...@gmail.com>wrote: > >>> > >>>> On Fri, Apr 26, 2013 at 12:28 PM, Greg Reddin <gred...@gmail.com> > >> wrote: > >>>> > >>>>> I'm a moderator. Assuming the mails don't cause the spam filter to be > >>>>> engaged, I'll moderate them through. > >>>> Great! I just sent out a test notification to > >> commits@flex.apache.orgfrom GitHub. Can you check if it came through? > >>>> > >>>> Another alternative would be to ask the committers to use their > >> apache.orgemail ids for their GitHub email ids. And we can select the > >> option of > >>>> GitHub sending the email from the Author's email. This way there is > no > >>>> moderation required because commits@f.a.o seems to allow all > >> apache.orgemail ids. > >>>> > >>>> GitHub validates the email addresses before it sends emails from those > >>>> addresses. > >>>> > >>>> Thanks, > >>>> Om > >>> > >>> > >>> I've sent another test email notification this time from my > >>> bigosma...@apache.org address. It did not automatically come through > as > >> I > >>> expected. Please take a look. > >>> > >>> Thanks, > >>> Om > >>> > >>> > >>>> > >>>> > >>>>> > >>>>> On Fri, Apr 26, 2013 at 2:25 PM, OmPrakash Muppirala > >>>>> <bigosma...@gmail.com>wrote: > >>>>> > >>>>>> On Fri, Apr 26, 2013 at 12:16 PM, Alex Harui <aha...@adobe.com> > >> wrote: > >>>>>> > >>>>>>> Om, > >>>>>>> > >>>>>>> Maybe I wasn't clear. I think a key aspect of whiteboards on > GitHub > >>>>> is > >>>>>> to > >>>>>>> have a commit to your whiteboard be seen on the > commits@flex.a.olistby > >>>>>>> anyone subscribed to commits@f.a.o without other work on their > part > >>>>> like > >>>>>>> signing up with GitHub or being added as a member of the an > >>>>>> "organization". > >>>>>>> > >>>>>>> We can't get an email to commits@f.a.o to happen for all activity > on > >>>>>> your > >>>>>>> whiteboard? > >>>>>> Short answer: it is doable. > >>>>>> > >>>>>> Long answer: > >>>>>> I can add an organization-wide notification setting to send emails > to: > >>>>>> comm...@flex.apache.org. The only problem is the list moderator > for > >>>>>> commits@f.a.o should manually add notificati...@github.com to the > >> list > >>>>> so > >>>>>> that the emails can go through. Who is the moderator of > commits@f.a.o > >> ? > >>>>>> > >>>>>> Thanks, > >>>>>> Om > >>>>>> > >>>>>> > >>>>>>> > >>>>>>> On 4/26/13 11:04 AM, "OmPrakash Muppirala" <bigosma...@gmail.com> > >>>>> wrote: > >>>>>>> > >>>>>>>> On Fri, Apr 26, 2013 at 10:51 AM, Alex Harui <aha...@adobe.com> > >>>>> wrote: > >>>>>>>> > >>>>>>>>> Om, > >>>>>>>>> > >>>>>>>>> Thanks for working on this. Some questions: > >>>>>>>>> > >>>>>>>>> 1) do you have this actually setup? If so, can you commit > >>>>> something > >>>>>> to > >>>>>>>>> your > >>>>>>>>> whiteboard so I can see what the notification email looks like? > >>>>>>>> > >>>>>>>> Yes, but with a private account. I can add you as a member of > this > >>>>>> test > >>>>>>>> organization. > >>>>>>>> We can 'watch' repos and notifications emails can be configured > [1], > >>>>>> [2] > >>>>>>>> More details on Organiations available here [3] > >>>>>>>> > >>>>>>>> > >>>>>>>>> 2) When the contributor sends the pull request, how does the > >>>>> committer > >>>>>>> get > >>>>>>>>> notified? Can an email go to the commits list? Or does the > >>>>>> committer > >>>>>>>>> only > >>>>>>>>> get notified off-list? > >>>>>>>> > >>>>>>>> We should be able to make the notifications go to any and multiple > >>>>>> email > >>>>>>>> ids [4]. We will have to add the <notificati...@github.com> > email > >>>>> id > >>>>>> to > >>>>>>>> our list. > >>>>>>>> > >>>>>>>> Thanks, > >>>>>>>> Om > >>>>>>>> > >>>>>>>> [1] https://help.github.com/articles/watching-repositories > >>>>>>>> [2] > >>>>> https://help.github.com/articles/configuring-notification-emails > >>>>>>>> [3] https://help.github.com/categories/2/articles > >>>>>>>> [4] > >>>>> > >> > https://help.github.com/articles/notifications#per-organization-email-routing > >>>>>>>> > >>>>>>>> > >>>>>>>>> > >>>>>>>>> -Alex > >>>>>>>>> > >>>>>>>>> On 4/26/13 10:27 AM, "OmPrakash Muppirala" <bigosma...@gmail.com > > > >>>>>>> wrote: > >>>>>>>>> > >>>>>>>>>> I have been experimenting with a GitHub based workflow for the > >>>>>>> whiteboard > >>>>>>>>>> repos for our committers. Here is the workflow I would like to > >>>>>>> propose: > >>>>>>>>>> > >>>>>>>>>> * Apache Flex creates an 'Organization' account GitHub > >>>>>>>>>> * Each Apache Flex committer is encouraged to create an account > on > >>>>>>> GitHub > >>>>>>>>>> * The committer then posts their GitHub id on > >>>>> dev@flex.apache.organd > >>>>>>>>> asks > >>>>>>>>>> to be added to the ApacheFlex@GitHub account > >>>>>>>>>> * The Apache Flex PMC will add the committer's GitHub id to the > >>>>>>>>>> ApacheFlex@GitHub account. > >>>>>>>>>> * In the contributing.md file [1] at the root of each > committer's > >>>>>>> github > >>>>>>>>>> project, there will be information about Apache's contribution > >>>>>>> guidelines > >>>>>>>>>> including a link to the ICLA [2] > >>>>>>>>>> * Any public contributor is free to fork an ApacheFlex > committer's > >>>>>>> github > >>>>>>>>>> project. > >>>>>>>>>> * The contributor makes a few modifications and is ready to > send a > >>>>>>> 'Pull > >>>>>>>>>> request' to the Apache Flex committer > >>>>>>>>>> * Before the 'Pull Request' can be sent, GitHub will > automatically > >>>>>>> point > >>>>>>>>>> the contributor to take a look at the contribution guidelines > >>>>> first. > >>>>>>>>>> * Theoretically the contributor reads the contribution > guidelines, > >>>>>>> agrees > >>>>>>>>>> to it implicitly and clicks the 'Send Pull Request' button. > >>>>>>>>>> * The Apache Flex Committer now will have a chance to peruse the > >>>>>>> commits > >>>>>>>>>> and decide whether or not to accept the pull request. > >>>>>>>>>> > >>>>>>>>>> There is another alternative I have been working on as well. > >>>>> There > >>>>>> is > >>>>>>> a > >>>>>>>>>> CLAHub [3] plugin for GitHub. The workflow for this is > described > >>>>> in > >>>>>>> the > >>>>>>>>>> same link [3]. I have been experimenting with this plugin but > >>>>> have > >>>>>>> found > >>>>>>>>>> various issues with it. I am currently working with the > plugin's > >>>>>>>>> creator, > >>>>>>>>>> Jason Morrison and support@GitHub to fix these issues. They > have > >>>>>> been > >>>>>>>>> very > >>>>>>>>>> helpful so far. I hope to be able to fix all the issues soon > and > >>>>>> send > >>>>>>>>> out > >>>>>>>>>> a demo. > >>>>>>>>>> > >>>>>>>>>> Please let me know if the above mentioned steps are sufficient > or > >>>>> if > >>>>>>>>>> something like CLAHub plugin would be better. > >>>>>>>>>> > >>>>>>>>>> Thanks, > >>>>>>>>>> Om > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> [1] https://github.com/blog/1184-contributing-guidelines > >>>>>>>>>> [2] http://www.apache.org/licenses/icla.txt > >>>>>>>>>> [3] http://www.clahub.com/ > >>>>>>>>> > >>>>>>>>> -- > >>>>>>>>> Alex Harui > >>>>>>>>> Flex SDK Team > >>>>>>>>> Adobe Systems, Inc. > >>>>>>>>> http://blogs.adobe.com/aharui > >>>>>>> > >>>>>>> -- > >>>>>>> Alex Harui > >>>>>>> Flex SDK Team > >>>>>>> Adobe Systems, Inc. > >>>>>>> http://blogs.adobe.com/aharui > >>>> > >>>> > >> > > -- > Alex Harui > Flex SDK Team > Adobe Systems, Inc. > http://blogs.adobe.com/aharui > >