Justin, This change is causing Mustella tests to fail for me in tests/RuntimeLocalization/RTL_SparkSkins/Modules.
Did these tests pass for you? The tests only compile in fr_FR, then set en_US in the locale chain before loading a resource module containing US resources. I tried setting the locale chain after the US resources get loaded, but the last test is trying to prove that you can load a resource module without automatically forcing the resources to update and setting the locale chain after loading causes that update. Also, there could be apps out there counting on this behavior. Thoughts? Maybe the bug associated with this fix [1] just needs some sort of check if the resource contains formatting characters? [1] https://issues.apache.org/jira/browse/FLEX-17210 -Alex On 4/30/13 5:26 PM, "jmcl...@apache.org" <jmcl...@apache.org> wrote: > Updated Branches: > refs/heads/develop 4738923f3 -> ae28ab34c > > > FLEX-17210 Added check to see if locale exists when changing localeChain > > > Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo > Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/ae28ab34 > Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/ae28ab34 > Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/ae28ab34 > > Branch: refs/heads/develop > Commit: ae28ab34c558957927471d54ce2a0ca6aace6207 > Parents: 4738923 > Author: Justin Mclean <jmcl...@apache.org> > Authored: Wed May 1 10:26:02 2013 +1000 > Committer: Justin Mclean <jmcl...@apache.org> > Committed: Wed May 1 10:26:02 2013 +1000 > > ---------------------------------------------------------------------- > .../src/mx/resources/ResourceManagerImpl.as | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) > ---------------------------------------------------------------------- > > > http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/ae28ab34/frameworks/proje > cts/framework/src/mx/resources/ResourceManagerImpl.as > ---------------------------------------------------------------------- > diff --git > a/frameworks/projects/framework/src/mx/resources/ResourceManagerImpl.as > b/frameworks/projects/framework/src/mx/resources/ResourceManagerImpl.as > index c138a9b..ef01ea6 100644 > --- a/frameworks/projects/framework/src/mx/resources/ResourceManagerImpl.as > +++ b/frameworks/projects/framework/src/mx/resources/ResourceManagerImpl.as > @@ -225,6 +225,15 @@ public class ResourceManagerImpl extends EventDispatcher > implements IResourceMan > public function set localeChain(value:Array /* of String */):void > { > _localeChain = value; > + > + for each (var locale:String in value) > + { > + if (!localeMap.hasOwnProperty(locale)) > + { > + throw new Error( > + "Could not find compiled locale '" + locale + "'."); > + } > + } > > update(); > } > -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
