GitHub just added support to closing an issue from a Pull Request (just include 
the special keyword syntax, fixes #2).
https://github.com/blog/1506-closing-issues-via-pull-requests

Bjorn :)

-----Original Message-----
From: Dasa Paddock [mailto:dpadd...@esri.com] 
Sent: Wednesday, May 15, 2013 11:08 AM
To: <dev@flex.apache.org>
Subject: Re: Git hub pull requests

I think the pull request would be automatically closed if the commit shas 
matched.

In this case, they do not match:
https://github.com/apache/flex-sdk/pull/2
79498c7 vs. 3e286fd

--Dasa

On May 15, 2013, at 9:05 AM, OmPrakash Muppirala <bigosma...@gmail.com> wrote:

> On May 15, 2013 8:37 AM, "Justin Mclean" <jus...@classsoftware.com> wrote:
>> 
>> Hi,
>> 
>> Hmm even when closed by the person who raised the pull request close it -
> it still shows up as unmerged here:
>> https://github.com/tomchiverton/flex-sdk/branches
>> 
>> Which is I guess technically correct as I applied the patch from the pull
> request not merged it.
>> 
>> Any ideas on how to resolve?
>> 
>> Thanks,
>> Justin
> 
> Ideally we would 'close' the pull request, but that requires admin access.


Reply via email to