In the README, I see mention of 'Apache Flex Pixel Bender' and 'Pixel Bender' and 'Adobe Pixel Bender'. We should consistently use the term 'Adobe Pixel Bender' when we refer to the software.
(more feedback son...) Thanks, Om On Sat, Dec 21, 2013 at 11:34 PM, Alex Harui <[email protected]> wrote: > Hi Justin, > > Thanks for finding these issues. I'll cut an RC4 in day or two in case > someone else gets a chance to look and finds something else. RC's are > cheap for this small a package and hopefully we'll never ship another one > so I might as well clean this stuff up. > > -Alex > > On 12/21/13 10:38 PM, "Justin Mclean" <[email protected]> wrote: > > >Hi, > > > >Two very minor issues with the documentation: > >- In README "ant -f pixelbender.xml." should probably be "ant -f > >pixelbender.xml" ie no period/full stop > >- RELEAE_NOTE doesn't state version number of release > > > >a few issues with ant targets: > >- project name is "framework" should probably be "pixel bender" > >- "copy-to-flex-sdk" is successful when pixel bender compiled files don't > >exist (eg after a clean) > >- "copy-to-flex-sdk" only works once, running it again doesn't copy the > >files. I think this is OK it just not copying files the second time as > >the date stamp is identical. > >- "copy-toflex-sdk" target states "copies PBK and PBJ files to Flex SDK > >folder" but only copies PBJ files. Should it copy both? > >- "clean" target states "Cleans third party downloaded files" which is > >not actually the case as there no 3rd party downloaded files. > > > >Everything else (hash and sign files correct, able to compile, git tag > >exists) is all good. Tested on OSX btw. > > > >Not sure if the minor issues above require a new RC or not, IMO probably > >not, any other opinions? > > > >Thanks, > >Justin > >
