Hi Alex, The way I implemented it, the download.xml would have downloaded one jar to a dedicated directory called utils. It shouldn't have any effect on the build except for a few kb of binary data downloaded.
But I'll try to make the download only download if the maven-artifacts target is selected. Chris -----Ursprüngliche Nachricht----- Von: Alex Harui [mailto:[email protected]] Gesendet: Freitag, 22. August 2014 17:36 An: [email protected] Betreff: Re: AW: Small "bug" in the falcon ant build The download.xml scripts are also used when FlexJS developers use the installer to install FlexJS. Any change you make will affect them so be careful. It would be preferred if there wasn't an extra download that doesn't help FlexJS developers, but on the other hand, unless it is a huge download, I'm not sure anybody will really notice. But yeah, I don't see a need for a branch. -Alex On 8/22/14 8:03 AM, "Christofer Dutz" <[email protected]> wrote: >Would there be any objections if I fixed that and pushed my addition to >the build script too? >It doesn't change anything with the current build (except download one >more jar) but if someone selects the target "maven-artifacts" it >installs falcon in your local maven repo. > >I sort of feel like a dedicated branch for this is sort of unnecessary, >but feel free to convince me otherwise. > >Hopefully with this, I will finally be able to quickly support falcon >in flemxojos :-) > >Chris > > >________________________________________ >Von: Alex Harui <[email protected]> >Gesendet: Freitag, 22. August 2014 16:51 >An: [email protected] >Betreff: Re: Small "bug" in the falcon ant build > >Good point. Feel free to fix. > >On 8/22/14 7:44 AM, "Christofer Dutz" <[email protected]> wrote: > >>?Hi, >> >> >>I am currently experimenting with maven-ant-tasks to create a maven >>version of falcon. For this I added an additional download to the >>download.xml. Now it seems I got the checksum wrong. What happened now >>is that the download script failed correctly. But I could see that it >>downloaded the file. The next time I execute the build, the tool sees >>the jar and doesn't re-check the checksum ... think this could be a >>problem ... >> >> >>Chris >
