I keep meaning to look into the scrollbar/border issue so I'll make that a priority.
When I started to make the charts to work on JS I created ChartDataGroup which is the parent of the itemRenderers. It created the parent <svg> element the renderers (which created just the SVG graphic element they needed) used. When I switched to core.graphics I made the renderers create divs. I think a GraphicsContainer would be a good idea, then I could make ChartDataGroup extend that and remove all the extra elements. Peter > On Sep 11, 2014, at 6:42 PM, "OmPrakash Muppirala" <bigosma...@gmail.com> > wrote: > > Peter, > > I just tested out the ChartExample app. It looks awesome! Thanks for > making this work end to end. Nice to see validation that using SVG lets us > do great visualizations that work exactly same in Flash and HTML5! > > A couple of things I noticed: > > 1. I see unnecessary horizontal and vertical scrollbars. It seems that > the the chart elements do not fit inside the div's width and height. > 2. I am looking at the HTML for the chart, for example:Gist here: > https://gist.github.com/bigosmallm/ae510538df51b8356d7d > > I see that we are creating a whole bunch of unnecessary divs and svg > elements. Would it be better if we created on SVG drawing canvas and drew > all the graphics inside it? It would make for a cleaner implementation and > better runtime performance. > > I am thinking that we will create a GraphicsContainer class which would > extend off of UIBase. Inside it would be one SVG element where you can > draw all the graphic elements in one co-ordinate space. > > Let me know what you think. > > Thanks, > Om
