Erik, Is it alright if I cherry pick this commit to the RC. Corrects a RTE for the spark datagrid / it's skin?
-Mark -----Original Message----- From: mkess...@apache.org [mailto:mkess...@apache.org] Sent: Monday, December 29, 2014 9:12 PM To: comm...@flex.apache.org Subject: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34710: s:DataGrid doubleClickMode was throwing an error when assigned a value in MXML. This was due to the grid part not being present yet. Modified the setter to use setGridProperty which allows delay Repository: flex-sdk Updated Branches: refs/heads/develop 789a0ca73 -> c47f9f9ec FLEX-34710: s:DataGrid doubleClickMode was throwing an error when assigned a value in MXML. This was due to the grid part not being present yet. Modified the setter to use setGridProperty which allows delayed property setting if needed. Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/c47f9f9e Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/c47f9f9e Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/c47f9f9e Branch: refs/heads/develop Commit: c47f9f9ec1bc53ad9e3cb48a51aee5c446229c30 Parents: 789a0ca Author: Mark Kessler <kesslerconsult...@gmail.com> Authored: Mon Dec 29 21:08:55 2014 -0500 Committer: Mark Kessler <kesslerconsult...@gmail.com> Committed: Mon Dec 29 21:08:55 2014 -0500 ---------------------------------------------------------------------- frameworks/projects/spark/src/spark/components/DataGrid.as | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/c47f9f9e/frameworks/projects/spark/src/spark/components/DataGrid.as ---------------------------------------------------------------------- diff --git a/frameworks/projects/spark/src/spark/components/DataGrid.as b/frameworks/projects/spark/src/spark/components/DataGrid.as index 8db0d85..9b17f60 100644 --- a/frameworks/projects/spark/src/spark/components/DataGrid.as +++ b/frameworks/projects/spark/src/spark/components/DataGrid.as @@ -1578,7 +1578,6 @@ public class DataGrid extends SkinnableContainerBase * @playerversion AIR 3.4 * @productversion Flex 4.10 */ - public function get doubleClickMode():String { return grid.doubleClickMode; @@ -1589,13 +1588,10 @@ public class DataGrid extends SkinnableContainerBase */ public function set doubleClickMode(newValue:String):void { - if (grid.doubleClickMode == newValue) + if (setGridProperty("doubleClickMode", newValue)) { - return; + dispatchChangeEvent("doubleClickModeChanged"); } - - grid.doubleClickMode = newValue; - dispatchChangeEvent("doubleClickModeChanged"); }