Hi,
Everything looks good to me (LICENCE and NOTICE, no binary files, all source
code has headers, compiles from source, pom looks good etc etc). Only one very
minor issue wrong year in NOTICE file (2014 rather than 2015).
Enough to give it a +1 vote IMO but I'm not sure how to use or test what is
produced.
I think the README.txt need to be updated a little, it says to do this:
java -cp target/flex-sdk-converter-1.0.jar SDKGenerator "{sdkhome}"
"{fdktarget}"
When I think the jar may be this one?
./converters/flex/target/flex-converter-1.0.0.jar
And while I can compile everything and it gives "SUCCESS" the target directory
is mostly empty:
ls -R target
maven-shared-archive-resources
target/maven-shared-archive-resources:
META-INF
target/maven-shared-archive-resources/META-INF:
DEPENDENCIES LICENSE NOTICE
But I do get other jars:
find . -name "*.jar" -print
./converters/air/target/air-converter-1.0.0.jar
./converters/base/target/base-converter-1.0.0.jar
./converters/flash/target/flash-converter-1.0.0.jar
./converters/flex/target/flex-converter-1.0.0.jar
./core/target/core-1.0.0.jar
./core/target/flex-sdk-converter-1.0.0.jar
./deployers/aether/target/aether-deployer-1.0.0-full.jar
./deployers/aether/target/aether-deployer-1.0.0.jar
./deployers/maven/target/maven-deployer-1.0.0-full.jar
./deployers/maven/target/maven-deployer-1.0.0.jar
./mavenizer/target/mavenizer-1.0.0.jar
./mavenizer/target/mavenizer.jar
./mavenizer/target/original-mavenizer.jar
./retrievers/base/target/base-retriever-1.0.0.jar
./retrievers/download/target/download-retriever-1.0.0.jar
Is this expected?
Thanks,
Justin
